Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][FIX] shopinvader: change url_key of all bindings in case of product renaming #485

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Oct 30, 2019

foward port of #470

@lmignon lmignon added the 12.0 label Oct 30, 2019
@lmignon lmignon mentioned this pull request Oct 30, 2019
77 tasks
@codecov-io
Copy link

Codecov Report

Merging #485 into 12.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             12.0     #485   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         104      104           
  Lines        2898     2898           
=======================================
  Hits         2645     2645           
  Misses        253      253
Impacted Files Coverage Δ
shopinvader/models/product_template.py 82.35% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c46c00...caf36e1. Read the comment docs.

@lmignon
Copy link
Collaborator Author

lmignon commented Oct 31, 2019

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-485-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Oct 31, 2019
Signed-off-by lmignon
@shopinvader-git-bot shopinvader-git-bot merged commit caf36e1 into shopinvader:12.0 Oct 31, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 1127f45. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 12.0-url_security branch October 31, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants