Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][FIX] shopinvader: change url_key of all bindings in case of product renaming #470

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

Cedric-Pigeon
Copy link

When the name of a product is changed, the url_key is recomputed. So a redirect is generated on the old url_key.

Currently, this is only done for the bindings in the current company.
This PR aims to fix this problem and trigger the redirect on all bindings whatever the company.

@Cedric-Pigeon Cedric-Pigeon changed the title [FIX] shopinvader: change url_key of all bindings in case of product renaming [10.0][FIX] shopinvader: change url_key of all bindings in case of product renaming Oct 22, 2019
@codecov-io
Copy link

Codecov Report

Merging #470 into 10.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             10.0     #470   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         139      139           
  Lines        3626     3626           
=======================================
  Hits         3241     3241           
  Misses        385      385
Impacted Files Coverage Δ
shopinvader/models/product_template.py 82.35% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1356deb...a40ca24. Read the comment docs.

@Cedric-Pigeon
Copy link
Author

this pr is 🍏

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@lmignon
Copy link
Collaborator

lmignon commented Oct 23, 2019

/ocabot merge patch

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 10.0-ocabot-merge-pr-470-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Oct 23, 2019
Signed-off-by lmignon
@lmignon lmignon mentioned this pull request Oct 23, 2019
77 tasks
@shopinvader-git-bot shopinvader-git-bot merged commit a40ca24 into shopinvader:10.0 Oct 23, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 67e458b. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants