-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][FIX] shopinvader: change url_key of all bindings in case of product renaming #470
[10.0][FIX] shopinvader: change url_key of all bindings in case of product renaming #470
Conversation
Codecov Report
@@ Coverage Diff @@
## 10.0 #470 +/- ##
=======================================
Coverage 89.38% 89.38%
=======================================
Files 139 139
Lines 3626 3626
=======================================
Hits 3241 3241
Misses 385 385
Continue to review full report at Codecov.
|
this pr is 🍏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems legit
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 67e458b. Thanks a lot for contributing to shopinvader. ❤️ |
When the name of a product is changed, the url_key is recomputed. So a redirect is generated on the old url_key.
Currently, this is only done for the bindings in the current company.
This PR aims to fix this problem and trigger the redirect on all bindings whatever the company.