Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated validateUrl option on short URL creation/edition #1679

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jan 23, 2023

Closes #1678

@codecov-commenter
Copy link

Codecov Report

Merging #1679 (4ee0032) into develop (06583a0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop    #1679   +/-   ##
==========================================
  Coverage      96.33%   96.33%           
  Complexity      1261     1261           
==========================================
  Files            232      232           
  Lines           4340     4340           
==========================================
  Hits            4181     4181           
  Misses           159      159           
Impacted Files Coverage Δ
.../ShortUrl/Helper/ShortUrlTitleResolutionHelper.php 100.00% <ø> (ø)
...odule/Core/src/ShortUrl/Model/ShortUrlCreation.php 70.00% <ø> (ø)
module/Core/src/ShortUrl/Model/ShortUrlEdition.php 69.86% <ø> (ø)
.../ShortUrl/Model/Validation/ShortUrlInputFilter.php 100.00% <ø> (ø)
module/Core/src/Util/UrlValidator.php 100.00% <ø> (ø)
...CLI/src/Command/ShortUrl/CreateShortUrlCommand.php 95.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@acelaya acelaya merged commit 8700767 into shlinkio:develop Jan 23, 2023
@acelaya acelaya deleted the feature/deprecate-url-validation branch January 23, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate validateUrl config option
2 participants