Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate validateUrl config option #1678

Closed
acelaya opened this issue Jan 22, 2023 · 0 comments · Fixed by #1679
Closed

Deprecate validateUrl config option #1678

acelaya opened this issue Jan 22, 2023 · 0 comments · Fixed by #1679
Labels
tech debt
Milestone
3.5.0

Comments

@acelaya
Copy link
Member

acelaya commented Jan 22, 2023

Based on the results of these two, looks like the extra complexity to validate URLs + resolve titles is not worth it:

Also, other services like Bit.ly do not validate them either.

The feature will be removed in Shlink 4.0.0, when URLs will no longer be validated at all.
@acelaya acelaya added this to the 3.5.0 milestone Jan 22, 2023
@acelaya acelaya added this to Shlink Jan 22, 2023
@acelaya acelaya moved this to Todo 🗒️ in Shlink Jan 22, 2023
@acelaya acelaya moved this from Todo 🗒️ to In Progress 📝 in Shlink Jan 23, 2023
@acelaya acelaya mentioned this issue Jan 23, 2023
Merged
@acelaya acelaya moved this from In Progress 📝 to In review 👀 in Shlink Jan 23, 2023
@github-project-automation github-project-automation bot moved this from In review 👀 to Done ✅ in Shlink Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
Shlink
Archived in project
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Deprecated validateUrl option on short URL creation/edition acelaya-forks/shlink
1 participant
@acelaya