Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/centralize multi segment #1496

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Aug 6, 2022

Closes #1495

@codecov-commenter
Copy link

Codecov Report

Merging #1496 (334aee6) into develop (4629f1b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop    #1496   +/-   ##
==========================================
  Coverage      96.82%   96.83%           
- Complexity      1242     1243    +1     
==========================================
  Files            208      209    +1     
  Lines           3623     3630    +7     
==========================================
+ Hits            3508     3515    +7     
  Misses           115      115           
Impacted Files Coverage Δ
...dule/Core/src/Config/MultiSegmentSlugProcessor.php 100.00% <100.00%> (ø)
module/Core/src/Repository/ShortUrlRepository.php 100.00% <100.00%> (ø)
module/Core/src/Repository/VisitRepository.php 100.00% <100.00%> (ø)
module/Core/src/Spec/InDateRange.php 100.00% <100.00%> (ø)
module/Rest/src/ConfigProvider.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@acelaya acelaya merged commit b9180be into shlinkio:develop Aug 6, 2022
@acelaya acelaya deleted the feature/centralize-multi-segment branch August 6, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move logic to append multi-segment slug route pattern to a config post processor
2 participants