Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic to append multi-segment slug route pattern to a config post processor #1495

Closed
acelaya opened this issue Aug 6, 2022 · 0 comments · Fixed by #1496
Closed

Move logic to append multi-segment slug route pattern to a config post processor #1495

acelaya opened this issue Aug 6, 2022 · 0 comments · Fixed by #1496
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Aug 6, 2022

Currently, the logic is in the routes.config.php file, and in the rest module ConfigProvider, which is called from the previous file.

That means the env var is read in two places, making it harder to override via config.

Remove the logic from the two files mentioned above, and the access to the env var, and create a post processor that iterates over all routes, and replaces {shortCode} by {shortCode:.+} if the config flag is true.

@acelaya acelaya added this to Shlink Aug 6, 2022
@acelaya acelaya moved this to Todo 🗒️ in Shlink Aug 6, 2022
@acelaya acelaya moved this from Todo 🗒️ to In Progress 📝 in Shlink Aug 6, 2022
@acelaya acelaya moved this from In Progress 📝 to In review 👀 in Shlink Aug 6, 2022
@acelaya acelaya closed this as completed Aug 6, 2022
Repository owner moved this from In review 👀 to Done ✅ in Shlink Aug 6, 2022
@acelaya acelaya added this to the 3.3.0 milestone Aug 7, 2022
@acelaya acelaya removed this from Shlink Aug 7, 2022
@acelaya acelaya added this to Shlink Aug 8, 2022
@acelaya acelaya moved this to Todo 🗒️ in Shlink Aug 8, 2022
@acelaya acelaya moved this from Todo 🗒️ to Done ✅ in Shlink Aug 8, 2022
@acelaya acelaya modified the milestones: 3.3.0, 3.2.1 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant