Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon in short URLs list indicating if a short URL has redirect rules #524

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 29, 2024

Closes #292

Add an icon indicating if a short URL has redirect rules. This icon is clickable and takes you to the rules edition page.

has-rules-2024-11-29_09.44.25.mp4

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.43%. Comparing base (98f8af2) to head (db3e0d8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/short-urls/helpers/ShortUrlDetailLink.tsx 50.00% 0 Missing and 1 partial ⚠️
src/short-urls/helpers/ShortUrlsRow.tsx 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   77.41%   77.43%   +0.01%     
==========================================
  Files         177      177              
  Lines        7227     7237      +10     
  Branches     1500     1501       +1     
==========================================
+ Hits         5595     5604       +9     
  Misses        162      162              
- Partials     1470     1471       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit cef8a9a into shlinkio:main Nov 29, 2024
8 checks passed
@acelaya acelaya deleted the feature/has-rules branch November 29, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display some indicator in short URLs list that redirect rules have been configured
1 participant