Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display some indicator in short URLs list that redirect rules have been configured #292

Closed
acelaya opened this issue Mar 17, 2024 · 2 comments · Fixed by #524
Closed

Display some indicator in short URLs list that redirect rules have been configured #292

acelaya opened this issue Mar 17, 2024 · 2 comments · Fixed by #524
Labels
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Mar 17, 2024

Right now, the only way to know if a short URL has redirect rules is to go to the redirect rules section. Add some kind of badge/label/indicator to know there are redirect rules for that short URLs.

This will require loading redirect rules for all the short URLs in the active page, so we could evolve the short url redirect rules reducer to handle a map instead of an instance (like the short URLs detail reducer does now). That way, when visiting the section from the list, we can pull the rules from there, avoiding an extra API call.

If the section is loaded "from scratch", then we load rules from the API (again, like with short URLs details).

@acelaya acelaya added this to Shlink Mar 17, 2024
@acelaya acelaya moved this to Todo in Shlink Aug 13, 2024
@acelaya acelaya added this to the 0.8.0 milestone Aug 13, 2024
@acelaya
Copy link
Member Author

acelaya commented Oct 7, 2024

I think I'm going to postpone this, as it's much easier to update the BE to return a flag indicating if a short URL has rules attached to it, rather than trying to overcomplicate the FE..

@acelaya acelaya removed this from the 0.8.0 milestone Oct 7, 2024
@acelaya acelaya removed the status in Shlink Oct 7, 2024
@acelaya acelaya moved this to Todo in Shlink Nov 25, 2024
@acelaya acelaya added this to the 0.11.0 milestone Nov 25, 2024
@acelaya
Copy link
Member Author

acelaya commented Nov 25, 2024

This is much easier now that Shlink 4.3 introduced hasRedirectRules property.

@acelaya acelaya moved this from In Progress to In review in Shlink Nov 29, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
1 participant