Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sanity check issues #624

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fix sanity check issues #624

merged 1 commit into from
Feb 26, 2021

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Fixing new issues that the sanity check reports. Probably due to a version update of the tool being used.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Feb 26, 2021
@openshift-ci-robot openshift-ci-robot added the release-note-none Label for when a PR does not need a release note label Feb 26, 2021
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Feb 26, 2021
Merged
qu1queee
qu1queee approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danke!
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit a7450ce into shipwright-io:master Feb 26, 2021
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-fix-sanity-check branch February 26, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@otaviof otaviof Awaiting requested review from otaviof

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SaschaSchwarze0 @openshift-ci-robot @qu1queee @openshift-merge-robot