Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Shipwright components away from "operator" #610

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

imjasonh
Copy link
Contributor

Changes

This change renames installed components to avoid the misnomer "operator". See #607 for full motivation and an outline of the changes.

Fixes #607

This change will require installations to uninstall any previous version of Shipwright before installing this new version -- naively kubectl applying this new config with a previous installation of Shipwright installed would result in two competing installations, which would probably not be fun.

Submitter Checklist

  • [n] Includes tests if functionality changed/was added
  • [n] Includes docs if changes are user-facing
  • [y] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

BREAKING: Change installation namespace, SA, ClusterRole{Binding}, and Deployment names

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Label for when a PR has specified a release note labels Feb 19, 2021
@imjasonh imjasonh added this to the release-v0.4.0 milestone Feb 22, 2021
@imjasonh imjasonh force-pushed the operator-yaml branch 5 times, most recently from 33afaa7 to ba467c7 Compare February 25, 2021 15:02
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021
@imjasonh imjasonh changed the title WIP: Rename Shipwright components away from "operator" Rename Shipwright components away from "operator" Feb 25, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2021
@qu1queee qu1queee requested a review from zhangtbj February 25, 2021 20:31
Copy link
Contributor

@zhangtbj zhangtbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the naming improvement. Review all naming change and tests passed.
LGTM

@qu1queee qu1queee self-requested a review February 26, 2021 09:26
cmd/controller/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only one question on a directory name change.

@qu1queee
Copy link
Contributor

@imjasonh I think we can merge this one today, but I would like this one to be a v0.4.0 release due to the amount of changes, maybe we can ship this today together.

@imjasonh imjasonh force-pushed the operator-yaml branch 3 times, most recently from 63a8270 to 05bd427 Compare February 26, 2021 11:43
@qu1queee
Copy link
Contributor

qu1queee commented Feb 26, 2021

@SaschaSchwarze0 is this pr failing sanity checks with the same issues you saw in #623 and that u addressed via 060e617 ?

@imjasonh
Copy link
Contributor Author

imjasonh commented Feb 26, 2021

@SaschaSchwarze0 is this pr failing sanity checks with the same issues you saw in #623 and that u addressed via 060e617 ?

Tests seem to be passing now.

I had a couple failures because I neglected to git add cmd/manager when I renamed it back 🤦‍♂️. Those seem to be fixed now though 🤞

edit: spoke too soon 😢
edit2: Yeah it looks like 060e617 would fix this

@SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 is this pr failing sanity checks with the same issues you saw in #623 and that u addressed via 060e617 ?

Yes, those are the same sanity check failures that appeared by magic (probably a change in the tool that we use).

@qu1queee
Copy link
Contributor

@imjasonh maybe just cherry-pick them from @SaschaSchwarze0 , while this PR is closer to get merge.

@imjasonh
Copy link
Contributor Author

imjasonh commented Feb 26, 2021

@imjasonh maybe just cherry-pick them from @SaschaSchwarze0 , while this PR is closer to get merge.

I'd rather make that change in a separate PR, since it's unrelated to this change.

@SaschaSchwarze0 are you sending that change in a different PR already? If not, I can make one for it.

edit: oh I see #623 now

@SaschaSchwarze0
Copy link
Member

@imjasonh maybe just cherry-pick them from @SaschaSchwarze0 , while this PR is closer to get merge.

I'd rather make that change in a separate PR, since it's unrelated to this change.

@SaschaSchwarze0 are you sending that change in a different PR already? If not, I can make one for it.

edit: oh I see #623 now

I can create a separate PR. One sec.

@SaschaSchwarze0
Copy link
Member

@qu1queee #624

@imjasonh
Copy link
Contributor Author

Thanks @SaschaSchwarze0 it looks like this passes sanity checks now 🎉

Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit 87778f1 into shipwright-io:master Feb 26, 2021
@gabemontero gabemontero added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Shipwright components away from "operator"
7 participants