-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Shipwright components away from "operator" #610
Rename Shipwright components away from "operator" #610
Conversation
33afaa7
to
ba467c7
Compare
ba467c7
to
90c95b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the naming improvement. Review all naming change and tests passed.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only one question on a directory name change.
@imjasonh I think we can merge this one today, but I would like this one to be a v0.4.0 release due to the amount of changes, maybe we can ship this today together. |
63a8270
to
05bd427
Compare
@SaschaSchwarze0 is this pr failing sanity checks with the same issues you saw in #623 and that u addressed via 060e617 ? |
Tests seem to be passing now. I had a couple failures because I neglected to edit: spoke too soon 😢 |
Yes, those are the same sanity check failures that appeared by magic (probably a change in the tool that we use). |
@imjasonh maybe just cherry-pick them from @SaschaSchwarze0 , while this PR is closer to get merge. |
I'd rather make that change in a separate PR, since it's unrelated to this change. @SaschaSchwarze0 are you sending that change in a different PR already? If not, I can make one for it. edit: oh I see #623 now |
I can create a separate PR. One sec. |
05bd427
to
7b80795
Compare
Thanks @SaschaSchwarze0 it looks like this passes sanity checks now 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This change renames installed components to avoid the misnomer "operator". See #607 for full motivation and an outline of the changes.
Fixes #607
This change will require installations to uninstall any previous version of Shipwright before installing this new version -- naively
kubectl apply
ing this new config with a previous installation of Shipwright installed would result in two competing installations, which would probably not be fun.Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes