Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings icons not being centered and plugin settings button not having propper styling #184

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Fix settings icons not being centered and plugin settings button not having propper styling #184

merged 1 commit into from
Dec 15, 2024

Conversation

tddebart
Copy link
Contributor

Just a simple fix for the settings icons not being centered

Before:
before themes
After:
after themes

Before:
before plugins
After:
after plugins

@shdwmtr shdwmtr merged commit 5fddc2d into shdwmtr:main Dec 15, 2024
@shdwmtr
Copy link
Owner

shdwmtr commented Dec 15, 2024

Thanks! I see you've come across the renderPluginSettings function (it seems), which is generally unfinished. You can implement portions of it if you need such a function, and I'll try to get the rest done (but don't feel obligated to).

Cheers!

@tddebart tddebart deleted the icon-fixes branch December 15, 2024 15:22
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
@semantic-release-bot
chore(release): 2.16.0 [skip ci]
3e7d93e 
# [2.16.0](v2.15.0...v2.16.0) (2024-12-19)

### Bug Fixes

* **CI:** Fix CI ([b897b49](b897b49))
* **CI:** Fix CI ([914df34](914df34))
* Close installer after successful install ([cfd961c](cfd961c))
* Fix plugin JS being removed from webkit when a new theme is selected. ([a29c7df](a29c7df))
* Fix settings icons not being centered and plugin settings button not having propper styling ([#184](#184)) ([5fddc2d](5fddc2d))
* Fix system accent color not working on some startups ([2eb7a94](2eb7a94))
* Fix the artifact CI ([3faf711](3faf711))
* Fix typo in install.sh ([#178](#178)) ([76349b3](76349b3)), closes [#4](#4)
* Fix typo on themes page [#168](#168) ([e05ec19](e05ec19))
* Prevent debug info from growing insanely large [#176](#176) ([d23bec9](d23bec9))
* **Unix:** Fix LD_PRELOAD variable interfering with Steam games. ([cbfd653](cbfd653))
* Use correct classes for Field ([#189](#189)) ([4ce6b5d](4ce6b5d))

### Features

* Add better webkit support for plugins ([33b6cde](33b6cde))
* Add Swedish localization. ([#180](#180)) ([0d9e8b4](0d9e8b4))
* Added CPS bypass & Added Millennium API to webkit modules ([eda0f54](eda0f54))
* Conditional webkit patching based on URL with regex [#127](#127) ([bf36bd5](bf36bd5))
* **Security:** Blacklist certain pages, like the checkout, from being injected into by plugins. ([54edc4c](54edc4c))
* Slightly Better Russian Translation ([#187](#187)) ([639390d](639390d))
* Softer and better crash detection. ([fc5e756](fc5e756))
* Updated plugin support for better webkit modding. ([1a8daf0](1a8daf0))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

shdwmtr added a commit that referenced this pull request Jan 4, 2025
@tddebart @dotFelixan
@ricewind012 @shdwmtr @semantic-release-bot
feat: Plugin settings rendering (#200)
13dc713 
* feat: Slightly Better Russian Translation (#187)

* Slightly Better Russian Translation

* Whoops

* fix: Use correct classes for Field (#189)

* fix: Fix plugin JS being removed from webkit when a new theme is selected.

* chore(release): bump version to v2.16.0 [skip ci]

* chore(release): 2.16.0 [skip ci]

# [2.16.0](v2.15.0...v2.16.0) (2024-12-19)

### Bug Fixes

* **CI:** Fix CI ([b897b49](b897b49))
* **CI:** Fix CI ([914df34](914df34))
* Close installer after successful install ([cfd961c](cfd961c))
* Fix plugin JS being removed from webkit when a new theme is selected. ([a29c7df](a29c7df))
* Fix settings icons not being centered and plugin settings button not having propper styling ([#184](#184)) ([5fddc2d](5fddc2d))
* Fix system accent color not working on some startups ([2eb7a94](2eb7a94))
* Fix the artifact CI ([3faf711](3faf711))
* Fix typo in install.sh ([#178](#178)) ([76349b3](76349b3)), closes [#4](#4)
* Fix typo on themes page [#168](#168) ([e05ec19](e05ec19))
* Prevent debug info from growing insanely large [#176](#176) ([d23bec9](d23bec9))
* **Unix:** Fix LD_PRELOAD variable interfering with Steam games. ([cbfd653](cbfd653))
* Use correct classes for Field ([#189](#189)) ([4ce6b5d](4ce6b5d))

### Features

* Add better webkit support for plugins ([33b6cde](33b6cde))
* Add Swedish localization. ([#180](#180)) ([0d9e8b4](0d9e8b4))
* Added CPS bypass & Added Millennium API to webkit modules ([eda0f54](eda0f54))
* Conditional webkit patching based on URL with regex [#127](#127) ([bf36bd5](bf36bd5))
* **Security:** Blacklist certain pages, like the checkout, from being injected into by plugins. ([54edc4c](54edc4c))
* Slightly Better Russian Translation ([#187](#187)) ([639390d](639390d))
* Softer and better crash detection. ([fc5e756](fc5e756))
* Updated plugin support for better webkit modding. ([1a8daf0](1a8daf0))

* fix: Properly handle theme config with invalid props.

* fix: Catch installer socket being used instead of crashing.

* fix: Fix unix pathing

* fix: Fix crashing on new installs

* chore(release): bump version to v2.16.1 [skip ci]

* chore(release): 2.16.1 [skip ci]

## [2.16.1](v2.16.0...v2.16.1) (2024-12-20)

### Bug Fixes

* Catch installer socket being used instead of crashing. ([8817735](8817735))
* Fix crashing on new installs ([9b7e1e5](9b7e1e5))
* Fix unix pathing ([07dc66c](07dc66c))
* Properly handle theme config with invalid props. ([d25461d](d25461d))

* fix: Fix installer crashes (again)

* chore(release): bump version to v2.16.2 [skip ci]

* chore(release): 2.16.2 [skip ci]

## [2.16.2](v2.16.1...v2.16.2) (2024-12-21)

### Bug Fixes

* Fix installer crashes (again) ([bfafcb7](bfafcb7))

* fix: Fix installer script

* fix: Add proxy support for web requests within Steam.

* fix: Fix webkit and CSP related issues. closes #197, #196, #194

* fix: Fix webkit issues, Close #194, #196

* fix: Fix webkit patcher edge cases on redirects

* feat: Add system accent color to webkit

* chore: Rename pipe

* chore: Remove debug logs

* chore: Fix linux

* fix: Fix webkit patcher skipping non-secure requests.

* Fix: prevent artifact builder from bumping the version

* chore(release): bump version to v2.17.0 [skip ci]

* chore(release): 2.17.0 [skip ci]

# [2.17.0](v2.16.2...v2.17.0) (2024-12-29)

### Bug Fixes

* Add proxy support for web requests within Steam. ([71dabc6](71dabc6))
* Fix installer script ([fb4053d](fb4053d))
* Fix webkit and CSP related issues. closes [#197](#197), [#196](#196), [#194](#194) ([e2cd49d](e2cd49d))
* Fix webkit issues, Close [#194](#194), [#196](#196) ([2c91a95](2c91a95))
* Fix webkit patcher edge cases on redirects ([2573215](2573215))
* Fix webkit patcher skipping non-secure requests. ([b9a6d0d](b9a6d0d))

### Features

* Add system accent color to webkit ([af602c3](af602c3))

* fix: Fix workshop pages not rendering HTML.

* chore(release): bump version to v2.17.1 [skip ci]

* chore(release): 2.17.1 [skip ci]

## [2.17.1](v2.17.0...v2.17.1) (2024-12-29)

### Bug Fixes

* Fix workshop pages not rendering HTML. ([4614cc8](4614cc8))

* fix: Fix overlay browser not loading on pages without a response phrase.

* chore(release): bump version to v2.17.2 [skip ci]

* chore(release): 2.17.2 [skip ci]

## [2.17.2](v2.17.1...v2.17.2) (2024-12-29)

### Bug Fixes

* Fix overlay browser not loading on pages without a response phrase. ([7d0fbcf](7d0fbcf))

* feat: Add embedded updater

* chore: CMake cleanup

* fix: allow frontend function to send booleans & numbers to backend (#198)

* fix: allow frontend function to send booleans to backend

* fix: allow frontend function to send numbers to backend

* feat(ipc): add support for fetching frontend settings from webkit context

* chore: integrate new settings framework in example plugin

* feat: render plugin settings modal based on plugin settings object

* fix: settings not receiving in other context when using tabs

---------

Co-authored-by: dotFelixan <[email protected]>
Co-authored-by: ricewind012 <[email protected]>
Co-authored-by: shadow <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tddebart @shdwmtr