Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Millennium settings are not visible/available when a language other than English is selected #4

Closed
Holt31 opened this issue Jun 15, 2023 · 0 comments

Comments

@Holt31
Copy link

Holt31 commented Jun 15, 2023

The title more or less says what the problem is.
For example, if the interface language is set to German in Steam, then Millennium's settings are not available.

If you now set the language to English, they reappear.

Example English:
Millennium-Settings-English

Example German:
Millennium-Settings-German

It is perfectly fine if Millennium is not translated, however the settings should at least be visible in the other languages.
You can also notice this by the fact that the settings skin is not loaded when the language is set to German.
(The design is not dark)

Edit:
As far as I read, it got fixed in the following pull request:
#2
It looks like this has not been publicly released yet.

@shdwmtr shdwmtr closed this as completed Jan 17, 2024
shdwmtr pushed a commit that referenced this issue Dec 13, 2024
Change line #4 to say Linux and not Windows
github-actions bot pushed a commit that referenced this issue Dec 19, 2024
# [2.16.0](v2.15.0...v2.16.0) (2024-12-19)

### Bug Fixes

* **CI:** Fix CI ([b897b49](b897b49))
* **CI:** Fix CI ([914df34](914df34))
* Close installer after successful install ([cfd961c](cfd961c))
* Fix plugin JS being removed from webkit when a new theme is selected. ([a29c7df](a29c7df))
* Fix settings icons not being centered and plugin settings button not having propper styling ([#184](#184)) ([5fddc2d](5fddc2d))
* Fix system accent color not working on some startups ([2eb7a94](2eb7a94))
* Fix the artifact CI ([3faf711](3faf711))
* Fix typo in install.sh ([#178](#178)) ([76349b3](76349b3)), closes [#4](#4)
* Fix typo on themes page [#168](#168) ([e05ec19](e05ec19))
* Prevent debug info from growing insanely large [#176](#176) ([d23bec9](d23bec9))
* **Unix:** Fix LD_PRELOAD variable interfering with Steam games. ([cbfd653](cbfd653))
* Use correct classes for Field ([#189](#189)) ([4ce6b5d](4ce6b5d))

### Features

* Add better webkit support for plugins ([33b6cde](33b6cde))
* Add Swedish localization. ([#180](#180)) ([0d9e8b4](0d9e8b4))
* Added CPS bypass & Added Millennium API to webkit modules ([eda0f54](eda0f54))
* Conditional webkit patching based on URL with regex [#127](#127) ([bf36bd5](bf36bd5))
* **Security:** Blacklist certain pages, like the checkout, from being injected into by plugins. ([54edc4c](54edc4c))
* Slightly Better Russian Translation ([#187](#187)) ([639390d](639390d))
* Softer and better crash detection. ([fc5e756](fc5e756))
* Updated plugin support for better webkit modding. ([1a8daf0](1a8daf0))
shdwmtr added a commit that referenced this issue Jan 4, 2025
* feat: Slightly Better Russian Translation (#187)

* Slightly Better Russian Translation

* Whoops

* fix: Use correct classes for Field (#189)

* fix: Fix plugin JS being removed from webkit when a new theme is selected.

* chore(release): bump version to v2.16.0 [skip ci]

* chore(release): 2.16.0 [skip ci]

# [2.16.0](v2.15.0...v2.16.0) (2024-12-19)

### Bug Fixes

* **CI:** Fix CI ([b897b49](b897b49))
* **CI:** Fix CI ([914df34](914df34))
* Close installer after successful install ([cfd961c](cfd961c))
* Fix plugin JS being removed from webkit when a new theme is selected. ([a29c7df](a29c7df))
* Fix settings icons not being centered and plugin settings button not having propper styling ([#184](#184)) ([5fddc2d](5fddc2d))
* Fix system accent color not working on some startups ([2eb7a94](2eb7a94))
* Fix the artifact CI ([3faf711](3faf711))
* Fix typo in install.sh ([#178](#178)) ([76349b3](76349b3)), closes [#4](#4)
* Fix typo on themes page [#168](#168) ([e05ec19](e05ec19))
* Prevent debug info from growing insanely large [#176](#176) ([d23bec9](d23bec9))
* **Unix:** Fix LD_PRELOAD variable interfering with Steam games. ([cbfd653](cbfd653))
* Use correct classes for Field ([#189](#189)) ([4ce6b5d](4ce6b5d))

### Features

* Add better webkit support for plugins ([33b6cde](33b6cde))
* Add Swedish localization. ([#180](#180)) ([0d9e8b4](0d9e8b4))
* Added CPS bypass & Added Millennium API to webkit modules ([eda0f54](eda0f54))
* Conditional webkit patching based on URL with regex [#127](#127) ([bf36bd5](bf36bd5))
* **Security:** Blacklist certain pages, like the checkout, from being injected into by plugins. ([54edc4c](54edc4c))
* Slightly Better Russian Translation ([#187](#187)) ([639390d](639390d))
* Softer and better crash detection. ([fc5e756](fc5e756))
* Updated plugin support for better webkit modding. ([1a8daf0](1a8daf0))

* fix: Properly handle theme config with invalid props.

* fix: Catch installer socket being used instead of crashing.

* fix: Fix unix pathing

* fix: Fix crashing on new installs

* chore(release): bump version to v2.16.1 [skip ci]

* chore(release): 2.16.1 [skip ci]

## [2.16.1](v2.16.0...v2.16.1) (2024-12-20)

### Bug Fixes

* Catch installer socket being used instead of crashing. ([8817735](8817735))
* Fix crashing on new installs ([9b7e1e5](9b7e1e5))
* Fix unix pathing ([07dc66c](07dc66c))
* Properly handle theme config with invalid props. ([d25461d](d25461d))

* fix: Fix installer crashes (again)

* chore(release): bump version to v2.16.2 [skip ci]

* chore(release): 2.16.2 [skip ci]

## [2.16.2](v2.16.1...v2.16.2) (2024-12-21)

### Bug Fixes

* Fix installer crashes (again) ([bfafcb7](bfafcb7))

* fix: Fix installer script

* fix: Add proxy support for web requests within Steam.

* fix: Fix webkit and CSP related issues. closes #197, #196, #194

* fix: Fix webkit issues, Close #194, #196

* fix: Fix webkit patcher edge cases on redirects

* feat: Add system accent color to webkit

* chore: Rename pipe

* chore: Remove debug logs

* chore: Fix linux

* fix: Fix webkit patcher skipping non-secure requests.

* Fix: prevent artifact builder from bumping the version

* chore(release): bump version to v2.17.0 [skip ci]

* chore(release): 2.17.0 [skip ci]

# [2.17.0](v2.16.2...v2.17.0) (2024-12-29)

### Bug Fixes

* Add proxy support for web requests within Steam. ([71dabc6](71dabc6))
* Fix installer script ([fb4053d](fb4053d))
* Fix webkit and CSP related issues. closes [#197](#197), [#196](#196), [#194](#194) ([e2cd49d](e2cd49d))
* Fix webkit issues, Close [#194](#194), [#196](#196) ([2c91a95](2c91a95))
* Fix webkit patcher edge cases on redirects ([2573215](2573215))
* Fix webkit patcher skipping non-secure requests. ([b9a6d0d](b9a6d0d))

### Features

* Add system accent color to webkit ([af602c3](af602c3))

* fix: Fix workshop pages not rendering HTML.

* chore(release): bump version to v2.17.1 [skip ci]

* chore(release): 2.17.1 [skip ci]

## [2.17.1](v2.17.0...v2.17.1) (2024-12-29)

### Bug Fixes

* Fix workshop pages not rendering HTML. ([4614cc8](4614cc8))

* fix: Fix overlay browser not loading on pages without a response phrase.

* chore(release): bump version to v2.17.2 [skip ci]

* chore(release): 2.17.2 [skip ci]

## [2.17.2](v2.17.1...v2.17.2) (2024-12-29)

### Bug Fixes

* Fix overlay browser not loading on pages without a response phrase. ([7d0fbcf](7d0fbcf))

* feat: Add embedded updater

* chore: CMake cleanup

* fix: allow frontend function to send booleans & numbers to backend (#198)

* fix: allow frontend function to send booleans to backend

* fix: allow frontend function to send numbers to backend

* feat(ipc): add support for fetching frontend settings from webkit context

* chore: integrate new settings framework in example plugin

* feat: render plugin settings modal based on plugin settings object

* fix: settings not receiving in other context when using tabs

---------

Co-authored-by: dotFelixan <[email protected]>
Co-authored-by: ricewind012 <[email protected]>
Co-authored-by: shadow <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants