Feature/prepare for pymodbus 3 9 0 #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l/closing management from remcom fork
…or definition file needs to be parsed to that current labels remain in place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pymodbus 3.9.0 has an new method and slightly different approach to reading registers.
An deprecation warning is printed by the library to indicate that this integration need to change the read (and write) register functions.
This PR will change the coordinator/hub logic to accomodate the new decoding way in place of the deprecated binarypayloaddecoder method.
After #279 is merged this pr can be merged (the changes in this pr will reduce due to this branch being based on the #279 pr)