Feature/backport the changes made on the remcom fork #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julesxxl
previously approved these changes
Jan 29, 2025
sfstar
dismissed
julesxxl’s stale review
The merge-base changed after approval.
sfstar
commented
Jan 29, 2025
sfstar
force-pushed
the
feature/backport_the_changes_made_on_the_remcom_fork
branch
from
6f80dd7 to
945ab89
Compare
sfstar
force-pushed
the
feature/backport_the_changes_made_on_the_remcom_fork
branch
from
945ab89 to
2335988
Compare
…l/closing management from remcom fork
…or definition file needs to be parsed to that current labels remain in place
|
current state of PR is that almost all changes have been backported and some extra workflow steps for auto scanning ruff have been added. Last changes are some CI related changes that still need to be ported. |
|
After further consideration this PR will only focus on the PORT and necessary CI changes to mature this repository. |
sfstar
changed the title
|
@sfstar Nice! i will review it this weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be merged after #278 is merged (also pr information needs expansion)changed has been merged.TODO's
Introduce linting workflow item (to allow this to be enforced)
~~ Try to get this to run inside an checked out version of ha core dev so that the ruff settings can be inherited ~~ <-- implementation in seperate PR to improve reviewability.
Backport all non-formatting related changes from the remcom fork
possibly: prepare for pymodbus 3.9.0 by hauling over decoding logic (to be moved to other pr if this PR becomes massive)(This will be done in a seperate PR to improve reviewability)