Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delete command for assets in sensuctl #988

Closed
amdprophet opened this issue Feb 7, 2018 · 6 comments · Fixed by #3185
Closed

Implement delete command for assets in sensuctl #988

amdprophet opened this issue Feb 7, 2018 · 6 comments · Fixed by #3185
Assignees
Labels
Milestone

Comments

@amdprophet
Copy link
Member

It looks like the "delete" functionality for assets is missing in sensuctl.

@amdprophet amdprophet added the bug label Feb 7, 2018
@jamesdphillips
Copy link
Contributor

At this point, I don't believe we've implemented it on any level. Deleting an asset has some obviously painful side-effects that require some discussion.

@grepory
Copy link
Contributor

grepory commented Apr 11, 2018

This is likely going to require some relational data between assets and checks, but we might want to do something like warn you if you're deleting an asset that's being used by checks, and then list which checks those are.

treydock added a commit to treydock/sensu-puppet that referenced this issue May 20, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue May 20, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue May 21, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue May 31, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue May 31, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue Jun 2, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue Dec 30, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue Dec 30, 2018
@avanier
Copy link

avanier commented Jun 6, 2019

Hey, I'll bump this guy. Having it would be a cool feature.

@annaplotkin
Copy link

This requires some thought around how we want to expose dependencies for assets (checks that use them for instance).

@ghost
Copy link

ghost commented Jul 31, 2019

Perhaps in the interim a force flag or something of the sorts could be provided?
It could just add a force:true key to the assets DELETE payload operation for validation.
Until there is a more graceful method this would give users a way to remove assets once they have down their own sanity checking.

@nikkictl
Copy link

MVP:

  • delete Asset resource only
  • tarball remains on disk (operator responsibility to clear the cache - DOCUMENT THIS)
  • checks, mutators, handlers, filters and hooks will likely fail to run until runtime_assets are updated in their respective configs
  • check/hook failures will be surfaced in event data
  • mutator/handler/filter failures will only be surfaced in backend logs
  • transparent documentation about the behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants