Unable to delete environment

[treydock]

Expected Behavior

I'd expect to delete an environment that has only been created during tests.

Current Behavior

/usr/bin/sensuctl environment delete test --skip-confirm

{"error":"environment is not empty","code":0}

Possible Solution

It would be handy if the resource keeping an environment from being deleted is printed. I can imagine this would be very expensive or verbose with lots of resources but in this case there should be nothing, see below.

Steps to Reproduce (for bugs)

Unsure how to reproduce as my acceptance testing will create resources then delete them so nothing should be persisting long enough to stay in a test environment.

Context

I am running acceptance tests for Puppet sensu module and an environment is created, modified then deleted and the deletion is failing. This only manifests itself when other resources before this environment are created. What's making this strange is nothing is added or modified while between environment creation and deletion attempt.

I'm unsure how to debug this issue as seems like this environment should have no resources associated with it and thus should be allowed to be deleted.

CC: @ghoneycutt

Your Environment

• Sensu version used (sensuctl, sensu-backend, and/or sensu-agent): Nightly as of 05/20/2018
• Installation method (packages, binaries, docker etc.): RPM
• Operating System and version (e.g. Ubuntu 14.04): EL7

[treydock]

Was able to reproduce inside Vagrant test environment

[root@sensu-backend ~]# sensuctl environment delete test
? Are you sure you would like to delete resource 'test'? Yes
Error: {"error":"environment is not empty","code":0}

I've not assigned anything to this environment.

Based on #333 I checked resources and what I found is a test asset with no environment shows up when I query with --environment test.

[root@sensu-backend ~]# for r in asset check entity handler mutator ; do sensuctl $r list --environment test ; done
  Name                URL                 Hash
 ────── ─────────────────────────────── ─────────
  test   //example.com/.../example.tar   4f926bf
  Name   Command   Interval   Cron   Timeout   TTL   Subscriptions   Handlers   Assets   Hooks   Publish?   Stdin?   Metric Format   Metric Handlers
 ────── ───────── ────────── ────── ───────── ───── ─────────────── ────────── ──────── ─────── ────────── ──────── ─────────────── ─────────────────
  ID   Class   OS   Subscriptions   Last Seen
 ──── ─────── ──── ─────────────── ───────────
  Name   Type   Timeout   Filters   Mutator   Execute   Environment Variables
 ────── ────── ───────── ───────── ───────── ───────── ───────────────────────
  Name   Command   Environment Variables   Timeout
 ────── ───────── ─────────────────────── ─────────

[root@sensu-backend ~]# sensuctl asset list --format json
[
  {
    "name": "test",
    "url": "http://example.com/asset/example.tar",
    "sha512": "4f926bf4328fbad2b9cac873d117f771914f4b837c9c85584c38ccf55a3ef3c2e8d154812246e5dda4a87450576b2c58ad9ab40c9e2edc31b288d066b195b21b",
    "metadata": null,
    "filters": [
      "System.OS==linux"
    ],
    "organization": "default"
  }
]

I don't know if this is the resource keeping the environment held but I can't delete the asset as that doesn't yet seem supported.

[echlebek]

We'd have to resolve the issue with assets not being able to be deleted first. See #988

[treydock]

Does an asset belong to all environments? I don't recall seeing an explicit environment assigned to assets when testing, only an organization.

[echlebek]

Looking at this again it appears you're correct! We are needlessly checking for the presence of assets when the environment is being deleted. Thanks. 👍