Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reuse existing EVM instance in interop calls (#1731)" #1780

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jul 24, 2024

This reverts commit f285e6f.

Describe your changes and provide context

Testing performed to validate your change

@codchen codchen requested a review from philipsu522 July 24, 2024 14:29
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.37%. Comparing base (aefdcf8) to head (aa36cc0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1780      +/-   ##
==========================================
- Coverage   61.47%   61.37%   -0.10%     
==========================================
  Files         257      256       -1     
  Lines       22284    22244      -40     
==========================================
- Hits        13698    13652      -46     
- Misses       7629     7635       +6     
  Partials      957      957              
Files Coverage Δ
evmrpc/simulate.go 64.72% <100.00%> (-0.51%) ⬇️
x/evm/ante/fee.go 64.00% <ø> (-0.48%) ⬇️
x/evm/keeper/msg_server.go 76.63% <ø> (-0.10%) ⬇️
x/evm/state/statedb.go 49.01% <0.00%> (-3.32%) ⬇️
x/evm/keeper/evm.go 66.66% <54.16%> (+0.21%) ⬆️

... and 2 files with indirect coverage changes

@philipsu522 philipsu522 merged commit c6dcfe0 into main Jul 24, 2024
47 of 49 checks passed
@philipsu522 philipsu522 deleted the revert-1-hop-disable branch July 24, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants