Reuse existing EVM instance in interop calls #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
- Coverage 61.52% 61.39% -0.14%
==========================================
Files 255 256 +1
Lines 22122 22162 +40
==========================================
- Hits 13611 13606 -5
- Misses 7556 7603 +47
+ Partials 955 953 -2
|
codchen
force-pushed
the
wasmd-return-ctx
branch
5 times, most recently
from
3cf6d41 to
fed14b5
Compare
stevenlanders
approved these changes
Jul 1, 2024
codchen
force-pushed
the
wasmd-return-ctx
branch
3 times, most recently
from
42caff6 to
73b3993
Compare
codchen
force-pushed
the
wasmd-return-ctx
branch
from
73b3993 to
da05c88
Compare
codchen
force-pushed
the
wasmd-return-ctx
branch
from
da05c88 to
01677c5
Compare
philipsu522
pushed a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Using new EVM instance for interop calls can cause discrepancies in behavior against ethereum. This PR changes the behavior to be reusing existing EVM instance, with an additional tweak which returns the latest
sdk.Contextfrom the evm instance to the wasmd message handler, so that there will never be a scenario where messages dispatched by a wasm call operate on differentsdk.Context.Testing performed to validate your change
existing integration test should still work