Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Talk about when to double number of bins #29

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Talk about when to double number of bins #29

merged 2 commits into from
Oct 17, 2019

Conversation

trishankatdatadog
Copy link
Collaborator

Fix #14

mnm678
mnm678 reviewed Oct 15, 2019
View reviewed changes
@joshuagl joshuagl mentioned this pull request Oct 16, 2019
Closed
lukpueh
lukpueh reviewed Oct 16, 2019
View reviewed changes
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I only have few minor comments.

@trishankatdatadog
Copy link
Collaborator Author

trishankatdatadog commented Oct 17, 2019 •
edited
Loading

@mnm678 @lukpueh can i plz haz your ✅? kthxbai

mnm678
mnm678 approved these changes Oct 17, 2019
View reviewed changes
Copy link
Collaborator

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuagl joshuagl mentioned this pull request Oct 17, 2019
Merged
@trishankatdatadog trishankatdatadog merged commit 24dea57 into secure-systems-lab:master Oct 17, 2019
@trishankatdatadog trishankatdatadog deleted the trishankatdatadog/doubling-targets branch October 17, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukpueh lukpueh lukpueh left review comments

@mnm678 mnm678 mnm678 approved these changes

@JustinCappos JustinCappos Awaiting requested review from JustinCappos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PEP 458: second draft
Development

Successfully merging this pull request may close these issues.

Number of bins
3 participants
@trishankatdatadog @lukpueh @mnm678