Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata scalability: more detail on hashed bins #19

Closed
joshuagl opened this issue Oct 14, 2019 · 3 comments
Closed

Metadata scalability: more detail on hashed bins #19

joshuagl opened this issue Oct 14, 2019 · 3 comments
Assignees

Comments

@joshuagl
Copy link

Caveat: I'm reviewing the PEP as a non-expert in attempt to help improve clarity, I hope these comments are useful.

Having read the "Metadata Scalability" section of the PEP and the "Delegate to Hashed Bins" section of the TUF tutorial, I can help but feel there's some detail missing on the hashed bins proposal.

As a reader looking to implement the PEP I'd like to better understand:

  • when should the number of bins increase?
  • are changes to the number of bins transparent to the client? i.e. does changing the number of bins require some kind of synchronisation between PyPI and its clients?
@joshuagl
Copy link
Author

The first question is at least partially answered by @trishankatdatadog in #29, the number of bins should increase when the number of targets increases to 4X the current number.

I think the second question is also answered indirectly - the changes to the number of bins is transparent, the client will be required to download a fresh set of metadata (as though it were a new user) but wouldn't require any explicit code logic or user interaction to do so.

Is my inference correct?

@trishankatdatadog
Copy link
Collaborator

@joshuagl yes 💯

@lukpueh
Copy link
Member

lukpueh commented Oct 17, 2019

Fixed with #37

@lukpueh lukpueh closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants