cdl_utils: remove unmaintained python library #29
Conversation
|
This package still seems to be available for python3 and it's source repository looks like it is still active. Do you have any links to more information about it not being maintained any more? |
|
It is available via distribution's package manager or pip. But the installation fails with setuptools, which is how cameks installs its dependency. More info can be found here danthedeckie/simpleeval#90 and danthedeckie/simpleeval#91 |
cdl_utils/capdl_linker.py
Outdated
| tcb.ip = eval(str(tcb.ip), {"__builtins__": None}, funcs) | ||
| tcb.sp = eval(str(tcb.sp), {"__builtins__": None}, funcs) | ||
| tcb.addr = eval(str(tcb.addr), {"__builtins__": None}, funcs) | ||
| tcb.init = eval(re.match("\[[0-9]*\]", str(tcb.init)).string) |
There was a problem hiding this comment.
There are examples of tcb.init needing to call get_vaddr: https://github.com/seL4/sel4-tutorials/blob/master/tools/context.py#L143, but it doesn't look like funcs is passed into this eval call.
There was a problem hiding this comment.
Thanks for pointing out, fixed.
Ok, thanks for the explanation |
simpleeval is no longer maintained. As the python setuptool has dropped python 2 support completely, it is unable to install simpleeval from source. Replacing it with the builtin eval(). It only takes input from camkes template, which is somewhat trusted. Simple sanity check is also added to filter out unexpected inputs. Signed-off-by: Siwei Zhuang <[email protected]>
simpleeval is no longer maintained. As the python setuptool has dropped
python 2 support completely, it is unable to install simpleeval from
source. Replacing it with the builtin eval(). It only takes input from
camkes template, which is somewhat trusted. Simple sanity check is also
added to filter out unexpected inputs.
Signed-off-by: Siwei Zhuang [email protected]