Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing install with latest setuptools (fails due to use_2to3 no longer supported) #90

Closed
aaronsteers opened this issue Sep 7, 2021 · 19 comments

Comments

@aaronsteers
Copy link

aaronsteers commented Sep 7, 2021

This option has dropped support: pypa/setuptools#2769

Failing builds downstream, such as in our project: https://gitlab.com/meltano/sdk/-/issues/213

Pending one-liner PR here: #91

@luigibertaco
Copy link

Having the same issue on an Google App Engine deploy, not able to deploy a new version until this is fixed.

Happy to help, will probably have some time this week if needed. Just a bit worried with a the release pace of the project.

@aaronsteers
Copy link
Author

aaronsteers commented Sep 7, 2021

I noticed VerdigrisTech has a more active fork in the Network graph: https://github.com/VerdigrisTech/simpleeval

image

However they don't accept issues so I opened a draft PR in attempt to start a conversation there: VerdigrisTech#2

Here, or there, would much appreciate anyone's support on this. I have zero familiarity with 2to3 or how difficult it would be to remove that option.

@aaronsteers
Copy link
Author

FWIW, tests here are passing: aaronsteers#2

That fork was created from the more active VerdigrisTech fork but it otherwise only changes setup.py and the GitHub workflow yml matrix.

@daenny
Copy link

daenny commented Sep 9, 2021

We have the same issue. Pinning setuptools to <58.0 solves this issue for now, but is not the solution in the long run. @danthedeckie Are you willing to accept PR's to this repo or have you stopped maintaining?

@roll
Copy link

roll commented Sep 20, 2021

Hi @danthedeckie, can you please take a look at this. It breaks all new installations of the Frictionless Framework - https://framework.frictionlessdata.io/. Your help is really appreciated.

@Norbo11
Copy link

Norbo11 commented Sep 24, 2021

For those that don't want to pin setuptools just replace simpleval in your requirements file with git+git://github.com/graingert/simpleeval@acd8455dec557d551aae1b37b708eb7cd025b03b to pick up the patch.

@aaronsteers
Copy link
Author

For those that don't want to pin setuptools just replace simpleval in your requirements file with git+git://github.com/graingert/simpleeval@acd8455 to pick up the patch.

Do we know if PyPi accept a publish with the git ref? I believe git refs in general are disallowed but I don't know if that changes when using a commit ref, as in the above.

@roll
Copy link

roll commented Sep 24, 2021

I tried to use a direct git ref in setup.py and it failed on CI during installation

@chris48s
Copy link

In a requirements.txt you can use git+git://github.com/graingert/simpleeval@acd8455dec557d551aae1b37b708eb7cd025b03b

In a setup.py the format is a bit different: https://www.python.org/dev/peps/pep-0508/#examples

Untested, but I think the equivalent for a setup.py would be:

install_requires = [
  'simpleeval @ https://github.com/graingert/simpleeval/archive/acd8455dec557d551aae1b37b708eb7cd025b03b.zip',
]

@roll
Copy link

roll commented Sep 26, 2021

Thanks @chris48s!

This syntax seems to be working. The one that had failed was simpleeval@git+https://[email protected]/roll/simpleeval@e2b37a96169a219613e1ffff3f38769d682e8596#egg=simpleeval


No, the one above also doesn't work:

https://github.com/pypa/gh-action-pypi-publish

HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
Invalid value for requires_dist. Error: Can't have direct dependency: 'simpleeval @ https://github.com/roll/simpleeval/archive/e2b37a96169a219613e1ffff3f38769d682e8596.zip'

@shearer12345
Copy link

Thanks @Norbo11 and @chris48s .

if you're using pyproject.toml (poetry) then the syntax is:
simpleeval = { git = "ssh://[email protected]/graingert/simpleeval.git", rev = "acd8455dec557d551aae1b37b708eb7cd025b03b" }

@istrupin
Copy link

For Pipenv, the syntax for the pipfile looks like:

simpleeval = {editable = true, ref = "acd8455dec557d551aae1b37b708eb7cd025b03b", git = "https://github.com/graingert/simpleeval"}

@Timost
Copy link

Timost commented Oct 13, 2021

update #91 has been merged so :
simpleeval = { git = "ssh://[email protected]/graingert/simpleeval.git", rev = "acd8455dec557d551aae1b37b708eb7cd025b03b" }

no longer works and one should use instead in pyproject.toml (poetry):

simpleeval = { git = "https://github.com/danthedeckie/simpleeval.git", rev = "8943b7f828f2fd610fd8546d474227041ecd494a" }

@transfluxus
Copy link

Hi,
I could install it with
git+git://github.com/graingert/simpleeval@acd8455
but I want to install another package that depends on simpleeval and it fails

@n1ngu
Copy link

n1ngu commented Oct 14, 2021

Hi, I could install it with git+git://github.com/graingert/simpleeval@acd8455 but I want to install another package that depends on simpleeval and it fails

I think the URI requirement is missing a fragment hinting pip it satisfies the simpleeval package like

git+git://github.com/graingert/simpleeval@master#simpleeval

@alhman
Copy link

alhman commented Oct 14, 2021

We created a PyPI package with the use_2to3 fix because we need it for our pdf reporting framework ReportBro. Maybe it is also useful for others:
https://pypi.org/project/reportbro-simpleeval/

@roll
Copy link

roll commented Oct 15, 2021

It's now merged. Can you please release it on PyPi?

@n1ngu
Copy link

n1ngu commented Oct 23, 2021

0.9.11 has been just released and installs just fine with latest setuptools 🎉

Everyone can stop pinning git commits and forks. @aaronsteers would you mind closing the issue?

Thanks everyone for the collaboration, specially @graingert for the prompt fix.

@aaronsteers
Copy link
Author

Confirmed! Thanks everyone! 🎉

https://pypi.org/project/simpleeval/0.9.11/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests