-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for deprecated cpuset
field
#2139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now treated as if it is always set to true regardless of its value.
This should be reflected in the API comment as well, otherwise this lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/assign tnozicka
It is now treated as if it is always set to true regardless of its value. Validation of ScyllaCluster resources is relaxed to not require full cores and resource requests == limits. Conditions for getting Guaranteed QoS class are explained in documentation.
done |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It is now treated as if it is always set to true regardless of its value.
Validation of ScyllaCluster resources is relaxed to not require full cores and resource requests == limits.
Conditions for getting Guaranteed QoS class are explained in documentation.
Fixes #2140