Move resolution of developerMode and additionalScyllaDBArguments to Operator #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimnx
added
kind/feature
scylla-operator-bot
bot
added
the
size/L
scylla-operator-bot
bot
added
the
approved
zimnx
force-pushed
the
sidecar-parameters
branch
from
a4eae74 to
cf5b5bd
Compare
rzetelskik
reviewed
Oct 2, 2024
helm/scylla-operator/templates/scyllacluster_member_clusterrole_def.yaml
Outdated
Show resolved
Hide resolved
This should go in a dedicated PR, especially for visibility. |
zimnx
force-pushed
the
sidecar-parameters
branch
from
cf5b5bd to
352c0e4
Compare
tnozicka
reviewed
Oct 2, 2024
zimnx
force-pushed
the
sidecar-parameters
branch
from
352c0e4 to
f4f707b
Compare
zimnx
changed the title
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
zimnx
force-pushed
the
sidecar-parameters
branch
from
f4f707b to
2b93f00
Compare
zimnx
force-pushed
the
sidecar-parameters
branch
from
2b93f00 to
3c1b469
Compare
extracted to separate PR #2139 |
zimnx
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
|
/hold for prereq #2139 |
scylla-operator-bot
bot
added
the
do-not-merge/hold
zimnx
force-pushed
the
sidecar-parameters
branch
from
3c1b469 to
858d3ba
Compare
scylla-operator-bot
bot
added
the
needs-rebase
|
#2139 landed |
scylla-operator-bot
bot
removed
the
do-not-merge/hold
zimnx
force-pushed
the
sidecar-parameters
branch
from
858d3ba to
a31126b
Compare
scylla-operator-bot
bot
removed
the
needs-rebase
zimnx
force-pushed
the
sidecar-parameters
branch
2 times, most recently
from
a578a31 to
281d62b
Compare
|
@rzetelskik @tnozicka ptal |
tnozicka
reviewed
Oct 8, 2024
zimnx
force-pushed
the
sidecar-parameters
branch
3 times, most recently
from
9a9a07b to
adb86f2
Compare
tnozicka
reviewed
Oct 9, 2024
zimnx
force-pushed
the
sidecar-parameters
branch
from
adb86f2 to
85f60ec
Compare
…to Operator Moves the resolution of developerMode and additionalScyllaDBArguments from the sidecar to the Operator. This change addresses an issue where modifications to these arguments did not trigger a rolling restart of the ScyllaDB cluster. By moving the logic to the Operator, any changes to these fields now correctly trigger a rolling restart as intended. Since the sidecar no longer needs to fetch the ScyllaCluster resource for these parameters, it no longer requires permissions to perform GET operations on ScyllaCluster objects. However, to ensure a safe rolling upgrade of the Operator, these permissions are not removed yet.
zimnx
force-pushed
the
sidecar-parameters
branch
from
85f60ec to
b55a97a
Compare
tnozicka
reviewed
Oct 10, 2024
|
/approve |
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zimnx
added a commit
to zimnx/scylla-operator
that referenced
this pull request
Dec 4, 2024
ScyllaDB contianer image enables developerMode if it's not explicitly disabled. It's the opposite logic to what we had in the past, which was changed in scylladb#2137 by mistake. This restores previous logic of explicitly disabling developerMode unless it's enabled in the API object.
zimnx
added a commit
to zimnx/scylla-operator
that referenced
this pull request
Dec 5, 2024
ScyllaDB contianer image enables developerMode if it's not explicitly disabled. It's the opposite logic to what we had in the past, which was changed in scylladb#2137 by mistake. This restores previous logic of explicitly disabling developerMode unless it's enabled in the API object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the resolution of
developerModeandadditionalScyllaDBArgumentsfrom the sidecar to the Operator.This change addresses an issue where modifications to these arguments did not trigger a rolling restart of the ScyllaDB cluster.
By moving the logic to the Operator, any changes to these fields now correctly trigger a rolling restart as intended.
Since the sidecar no longer needs to fetch the ScyllaCluster resource for these parameters, it no longer requires permissions to perform GET operations on ScyllaCluster objects.
However, to ensure a safe rolling upgrade of the Operator, these permissions are not removed yet.
Additionally, this commit removes support for the deprecated
cpusetfield. It is now treated as if it is always set to true regardless of its value.Requires:
cpusetfield #2139Fixes #1389