Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use broadcast_address for seeds in external seeds E2E #1984

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Use broadcast_address for seeds in external seeds E2E #1984

merged 2 commits into from
Jun 21, 2024

Conversation

rzetelskik
Copy link
Member

Description of your changes:
This PR makes the e2e test covering manual multi-datacenter setup use broadcast_address for seeds. It also unifies the usage of framework interface in this test.

Which issue is resolved by this Pull Request:
Resolves #1983

/kind feature
/priority important-soon
/cc

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes:
This PR makes the e2e test covering manual multi-datacenter setup use broadcast_address for seeds. It also unifies the usage of framework interface in this test.

Which issue is resolved by this Pull Request:
Resolves #1983

/kind feature
/priority important-soon
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2024
@rzetelskik rzetelskik mentioned this pull request Jun 21, 2024
Merged
@rzetelskik rzetelskik force-pushed the external-seeds-broadcast-address branch from 32af145 to e264c6a Compare June 21, 2024 15:35
@rzetelskik rzetelskik requested a review from zimnx June 21, 2024 15:36
zimnx
zimnx approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit 77bd49d into scylladb:master Jun 21, 2024
12 checks passed
@tnozicka tnozicka added kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E test for manual multi-datacenter setup should use broadcast_address for seeds
3 participants
@rzetelskik @zimnx @tnozicka