-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an E2E test suite for multi-datacenter clusters #1953
Add an E2E test suite for multi-datacenter clusters #1953
Conversation
Skipping CI for Draft Pull Request. |
@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik. Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c03e516
to
861cad3
Compare
861cad3
to
33487c8
Compare
This will only be able to run once https://github.com/scylladb/scylla-operator-release/pull/81 is unblocked, but should be ready for review by itself. |
/retest |
/hold |
d7c2f48
to
8cefefe
Compare
/hold cancel |
/test e2e-gke-multi-datacenter-parallel |
test/e2e/set/scyllacluster/multi_datacenter_scyllacluster_external_seeds.go
Outdated
Show resolved
Hide resolved
test/e2e/set/scyllacluster/multi_datacenter_scyllacluster_external_seeds.go
Outdated
Show resolved
Hide resolved
test/e2e/set/scyllacluster/multi_datacenter_scyllacluster_external_seeds.go
Show resolved
Hide resolved
8cefefe
to
29c6a35
Compare
29c6a35
to
946dc9a
Compare
#1028 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/assign tnozicka
/test images e2e-gke-parallel-clusterip |
test/e2e/set/scyllacluster/multi_datacenter_scyllacluster_external_seeds.go
Outdated
Show resolved
Hide resolved
test/e2e/set/scyllacluster/multi_datacenter_scyllacluster_external_seeds.go
Outdated
Show resolved
Hide resolved
test/e2e/set/scyllacluster/multi_datacenter_scyllacluster_external_seeds.go
Outdated
Show resolved
Hide resolved
test/e2e/set/scyllacluster/multi_datacenter_scyllacluster_external_seeds.go
Outdated
Show resolved
Hide resolved
test/e2e/set/scyllacluster/multi_datacenter_scyllacluster_external_seeds.go
Outdated
Show resolved
Hide resolved
test/e2e/set/scyllacluster/multi_datacenter_scyllacluster_external_seeds.go
Outdated
Show resolved
Hide resolved
02d455c
to
f32310a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates, 2 nits
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1f91878
to
ce7c5d7
Compare
Applied. Also aligned Cluster/Namespace/ScyllaCluster indexing, I forgot about it earlier. |
thx, that one was truly optional /lgtm |
@rzetelskik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ce7c5d7
to
e0c2125
Compare
Didn't notice a whitespace there... |
/lgtm |
3cf8a4a
into
scylladb:master
Description of your changes: This PR introduces a multi-datacenter E2E test suite with a basic test verifying a multi-datacenter cluster can form across multiple Kubernetes clusters, using external seeds to connect datacenters.
Which issue is resolved by this Pull Request:
Resolves
Requires:
/kind feature
/priority important-longterm
/cc