Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an E2E test suite for multi-datacenter clusters #1953

Merged

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Jun 4, 2024

Description of your changes: This PR introduces a multi-datacenter E2E test suite with a basic test verifying a multi-datacenter cluster can form across multiple Kubernetes clusters, using external seeds to connect datacenters.

Which issue is resolved by this Pull Request:
Resolves

Requires:

/kind feature
/priority important-longterm
/cc

Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: This PR introduces a multi-datacenter E2E test suite with a basic test verifying a multi-datacenter cluster can form across multiple Kubernetes clusters, using external seeds to connect datacenters.

Which issue is resolved by this Pull Request:
Resolves #1320

Requires:

/kind feature
/priority important-longterm
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2024
@rzetelskik rzetelskik marked this pull request as ready for review June 4, 2024 10:15
@scylla-operator-bot scylla-operator-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 4, 2024
@rzetelskik rzetelskik force-pushed the multi-datacenter-e2e branch from c03e516 to 861cad3 Compare June 10, 2024 08:35
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2024
@rzetelskik rzetelskik force-pushed the multi-datacenter-e2e branch from 861cad3 to 33487c8 Compare June 10, 2024 08:43
@rzetelskik
Copy link
Member Author

This will only be able to run once https://github.com/scylladb/scylla-operator-release/pull/81 is unblocked, but should be ready for review by itself.
/cc zimnx
/assign zimnx

@rzetelskik
Copy link
Member Author

rzetelskik commented Jun 10, 2024

/retest
cluster provisioning failed

@rzetelskik
Copy link
Member Author

/hold
for an optional presubmit with multi-datacenter infra

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024
@rzetelskik rzetelskik changed the title Add an E2E test suite for multi-datacenter clusters [WIP] Add an E2E test suite for multi-datacenter clusters Jun 19, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2024
@rzetelskik rzetelskik force-pushed the multi-datacenter-e2e branch 2 times, most recently from d7c2f48 to 8cefefe Compare June 20, 2024 12:32
@rzetelskik rzetelskik changed the title [WIP] Add an E2E test suite for multi-datacenter clusters Add an E2E test suite for multi-datacenter clusters Jun 20, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2024
@rzetelskik
Copy link
Member Author

/hold cancel
@zimnx presubmit passed, ready for review

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2024
@rzetelskik
Copy link
Member Author

/test e2e-gke-multi-datacenter-parallel

@rzetelskik rzetelskik requested a review from zimnx June 21, 2024 13:52
@rzetelskik rzetelskik force-pushed the multi-datacenter-e2e branch from 29c6a35 to 946dc9a Compare June 21, 2024 15:38
@rzetelskik
Copy link
Member Author

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel-clusterip 946dc9a link true /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

#1028 (comment)
unrelated
/retest

Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign tnozicka

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@rzetelskik rzetelskik requested a review from tnozicka June 24, 2024 13:22
@rzetelskik
Copy link
Member Author

/test images e2e-gke-parallel-clusterip

@rzetelskik rzetelskik force-pushed the multi-datacenter-e2e branch 2 times, most recently from 02d455c to f32310a Compare June 26, 2024 12:29
@rzetelskik rzetelskik requested a review from tnozicka June 26, 2024 12:30
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates, 2 nits
/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik rzetelskik force-pushed the multi-datacenter-e2e branch 2 times, most recently from 1f91878 to ce7c5d7 Compare June 26, 2024 13:17
@rzetelskik
Copy link
Member Author

thanks for the updates, 2 nits /approve

Applied. Also aligned Cluster/Namespace/ScyllaCluster indexing, I forgot about it earlier.

@tnozicka
Copy link
Contributor

thx, that one was truly optional

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link
Contributor

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-multi-datacenter-parallel ce7c5d7 link false /test e2e-gke-multi-datacenter-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rzetelskik rzetelskik force-pushed the multi-datacenter-e2e branch from ce7c5d7 to e0c2125 Compare June 26, 2024 14:09
@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@rzetelskik
Copy link
Member Author

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-multi-datacenter-parallel ce7c5d7 link false /test e2e-gke-multi-datacenter-parallel
Full PR test history. Your PR dashboard.

Invalid value: "a ": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

Didn't notice a whitespace there...
Fixed, @tnozicka please tag again.

@tnozicka
Copy link
Contributor

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit 3cf8a4a into scylladb:master Jun 26, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants