Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Scylla Manager repair and backup task integration E2E tests #1891

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

rzetelskik
Copy link
Member

Description of your changes: This PR doesn't really bring any value in itself, but the test split allows for making the changes required for #1742 clearer, consequently making the review process easier.

Which issue is resolved by this Pull Request:
Prerequisite for #1742

/kind feature
/priority important-longterm
/cc

Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: This PR doesn't really bring any value in itself, but the test split allows for making the changes required for #1742 clearer, consequently making the review process easier.

Which issue is resolved by this Pull Request:
Prerequisite for #1742

/kind feature
/priority important-longterm
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2024
@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel-clusterip 3787e95 link true /test e2e-gke-parallel-clusterip

https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1891/pull-scylla-operator-master-e2e-gke-parallel-clusterip/1779805444886237184#1:test-build-log.txt%3A948

Stuck on repair task deletion integration.
Controller issued task deletion:

2024-04-15T10:03:39.679445365Z I0415 10:03:39.621523       1 manager/sync.go:134] "Executing action" action="delete task \"4bd2d3d8-419c-4355-acf5-423666addec9\""
...
2024-04-15T10:03:39.679523675Z I0415 10:03:39.641612       1 manager/controller.go:148] "Hit conflict, will retry in a bit" Key="e2e-test-scyllacluster-8gx9r-w6wn4/basic-2mzvl" Error="Operation cannot be fulfilled on scyllaclusters.scylla.scylladb.com \"basic-2mzvl\": the object has been modified; please apply your changes to the latest version and try again"

Manager doesn't have related logs.
Wasn't propagated to status.
Working on it as part of #1850.

#1694 (comment)

ci/prow/e2e-gke-parallel 3787e95 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

Stuck on repair task deletion integration.
Controller issued task deletion:

2024-04-15T10:03:20.346661594Z I0415 10:03:20.346612       1 manager/sync.go:134] "Executing action" action="delete task \"8c1bfa4c-e08c-41ab-b5ac-6dedd51b7ede\""
...
2024-04-15T10:03:20.434715683Z I0415 10:03:20.374406       1 manager/controller.go:148] "Hit conflict, will retry in a bit" Key="e2e-test-scyllacluster-2j6b9-r
gxkv/basic-qf87f" Error="Operation cannot be fulfilled on scyllaclusters.scylla.scylladb.com \"basic-qf87f\": the object has been modified; please apply your c
hanges to the latest version and try again"

Manager doesn't have related logs.
Wasn't propagated to status.
Working on it as part of #1850.

#1694 (comment)

/retest

@rzetelskik
Copy link
Member Author

/cc zimnx tnozicka

@scylla-operator-bot scylla-operator-bot bot requested review from tnozicka and zimnx April 15, 2024 11:05
@scylladb scylladb deleted a comment from scylla-operator-bot bot Apr 15, 2024
@rzetelskik
Copy link
Member Author

/test e2e-gke-parallel-clusterip
cluster provisioning failed

@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel 3787e95 link true /test e2e-gke-parallel

ditto
#1694 (comment)

ci/prow/e2e-gke-parallel-clusterip 3787e95 link true /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

ditto
#1694 (comment)

/retest

@tnozicka
Copy link
Contributor

/approve
/assign @zimnx

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 57ab171 into scylladb:master Apr 15, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants