Validate whether Scylla container is tuned before Pod is unblocked #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimnx
added
kind/bug
scylla-operator-bot
bot
added
approved
zimnx
changed the title
zimnx
changed the title
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
zimnx
force-pushed
the
container-is-tuned
branch
3 times, most recently
from
f2fc722 to
9a4263d
Compare
zimnx
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
tnozicka
approved these changes
Mar 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Scylla Pod was unblocked even when container wasn't yet tuned. E2E validating node optimizations wasn't validating it either giving us a false positive.
zimnx
force-pushed
the
container-is-tuned
branch
from
9a4263d to
1b9c04a
Compare
|
@zimnx: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
scylla-operator-bot
bot
added
the
lgtm
|
Provisioning failed + #1802 (comment) /retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scylla Pod was unblocked even when container wasn't yet tuned. E2E validating node optimizations wasn't validating it either giving us a false positive.
Fixes #1856