Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scylla Pod is unblocked even when tuning fails #1856

Closed
zimnx opened this issue Mar 20, 2024 · 1 comment · Fixed by #1857
Closed

Scylla Pod is unblocked even when tuning fails #1856

zimnx opened this issue Mar 20, 2024 · 1 comment · Fixed by #1857
Assignees
@zimnx
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@zimnx
Copy link
Collaborator

zimnx commented Mar 20, 2024

Operator Sidecar waits until all matching NodeConfig's are done with tuning, but it only validates whether Node where given Pod is running is done. It doesn't wait until Scylla container is tuned.

This causes that E2E validating our node tuning gives us a false positive, as even when tuning fails, Scylla Pod is started.
@zimnx zimnx added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 20, 2024
@zimnx zimnx self-assigned this Mar 20, 2024
@zimnx zimnx mentioned this issue Mar 20, 2024
Merged
@zimnx
Copy link
Collaborator Author

zimnx commented Mar 20, 2024

#1826 wasn't catched earlier because of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zimnx zimnx

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate whether Scylla container is tuned before Pod is unblocked zimnx/scylla-operator
1 participant
@zimnx