Add mapstructure tag to backup task spec and fix conversion funcs #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scylla-operator-bot
bot
added
the
kind/bug
scylla-operator-bot
bot
added
priority/critical-urgent
rzetelskik
changed the title
scylla-operator-bot
bot
added
the
approved
rzetelskik
force-pushed
the
manager-task-spec-mapstructure
branch
from
36d3d3f to
b897735
Compare
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes: This PR addresses a missing mapstructure tag in BackupTaskStatus, causing the conversion between our and manager api to miss task properties entirely.
The mapstructure is used in functions converting managerclient structs to our internal specs:
scylla-operator/pkg/controller/manager/types_old.go
Line 86 in 1520cf7
At this point this is one of the issues behind unnecessary updates #1827, but it's also required for fixing status synchronisation: #1850, hence the priority.
This PR also fixes manager task conversion func bug and adds unit tests covering the conversion.
Which issue is resolved by this Pull Request:
Resolves #1852
/kind bug
/priority critical-urgent