Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing mapstructure tag in BackupTaskStatus #1852

Closed
rzetelskik opened this issue Mar 20, 2024 · 1 comment · Fixed by #1854
Closed

Missing mapstructure tag in BackupTaskStatus #1852

rzetelskik opened this issue Mar 20, 2024 · 1 comment · Fixed by #1854
Assignees
@rzetelskik
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@rzetelskik
Copy link
Member

What happened?

Inlined BackupTaskSpec in BackupTaskStatus is missing a mapstructure tag

scylla-operator/pkg/api/scylla/v1/types_cluster.go

Line 600 in 1520cf7

BackupTaskSpec `json:",inline"`

It causes the conversion between our and managerclient APIs to miss the task properties entirely.

/kind bug

What did you expect to happen?

It should have the mapstructure:",squash" tag.

How can we reproduce it (as minimally and precisely as possible)?

n/a

Scylla Operator version

master

Kubernetes platform name and version

n/a

Please attach the must-gather archive.

n/a

Anything else we need to know?

One of the many issues behind #1827 and a prerequisite for #1752.
@rzetelskik rzetelskik added the kind/bug Categorizes issue or PR as related to a bug. label Mar 20, 2024
@scylla-operator-bot scylla-operator-bot bot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 20, 2024
@rzetelskik
Copy link
Member Author

/priority critical-urgent
since this is a prerequisite for #1752

@scylla-operator-bot scylla-operator-bot bot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 20, 2024
@rzetelskik rzetelskik mentioned this issue Mar 20, 2024
Merged
@rzetelskik rzetelskik self-assigned this Mar 20, 2024
@rzetelskik rzetelskik mentioned this issue Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzetelskik rzetelskik

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mapstructure tag to backup task spec and fix conversion funcs rzetelskik/scylla-operator
1 participant
@rzetelskik