Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize must-gather command #1804

Merged
merged 1 commit into from
May 6, 2024
Merged

Parametrize must-gather command #1804

merged 1 commit into from
May 6, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Mar 8, 2024

Description of your changes:

This allows to reuse must-gather implementation with custom list of resource groups to collect.

@zimnx zimnx added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 8, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2024
@zimnx zimnx force-pushed the mz/parametrize-must-gather branch from 1171c61 to 611246e Compare March 11, 2024 17:24
@zimnx
Copy link
Collaborator Author

zimnx commented Mar 12, 2024

Flake #1694 (comment)
/retest

@zimnx
Copy link
Collaborator Author

zimnx commented Mar 19, 2024

/retest

@zimnx
Copy link
Collaborator Author

zimnx commented Mar 19, 2024

/test e2e-gke-parallel-clusterip
/test images

rzetelskik
rzetelskik approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I don't have a strong opinion on the options pattern - unnecessary for the public field but I don't see anything wrong with it per se
/assign tnozicka

tnozicka
tnozicka reviewed Apr 18, 2024
View reviewed changes
@zimnx
Parametrize must-gather command
339a5e6 
This allows to reuse must-gather implementation with custom list of resources to collect
@zimnx zimnx force-pushed the mz/parametrize-must-gather branch from 611246e to 339a5e6 Compare April 23, 2024 14:07
@scylla-operator-bot scylla-operator-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2024
@zimnx zimnx requested a review from tnozicka April 23, 2024 14:11
@zimnx
Copy link
Collaborator Author

zimnx commented Apr 23, 2024

Flake - #1028 (comment)
Deadline exceeded on network connection, not related to this PR.
/test e2e-gke-parallel-clusterip

@zimnx
Copy link
Collaborator Author

zimnx commented Apr 23, 2024

Known manager flake
/test e2e-gke-parallel-clusterip

tnozicka
tnozicka approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor

tnozicka commented May 2, 2024

/retest

1 similar comment
@zimnx
Copy link
Collaborator Author

zimnx commented May 6, 2024

/retest

@zimnx
Copy link
Collaborator Author

zimnx commented May 6, 2024

/test e2e-gke-parallel-clusterip
/test images

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented May 6, 2024 •
edited
Loading

@zimnx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 611246e link true /test e2e-gke-release-script-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zimnx
Copy link
Collaborator Author

zimnx commented May 6, 2024

Known Manager flake
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit dce40d8 into scylladb:master May 6, 2024
12 checks passed
@zimnx zimnx added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jun 19, 2024
@zimnx zimnx deleted the mz/parametrize-must-gather branch June 19, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@rzetelskik rzetelskik rzetelskik approved these changes

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zimnx @tnozicka @rzetelskik