Merge pull request #1804 from zimnx/mz/parametrize-must-gather

Parametrize must-gather command

pkg/cmd/operator/mustgather.go

@@ -46,14 +46,18 @@ var (
 type MustGatherOptions struct {
 	*GatherBaseOptions
 
-	AllResources bool
+	AllResources            bool
+	CollectedResourceGroups []GroupResourceSpec
 }
 
 func NewMustGatherOptions(streams genericclioptions.IOStreams) *MustGatherOptions {
-	return &MustGatherOptions{
-		GatherBaseOptions: NewGatherBaseOptions("scylla-operator-must-gather", true),
-		AllResources:      false,
+	options := &MustGatherOptions{
+		GatherBaseOptions:       NewGatherBaseOptions("scylla-operator-must-gather", true),
+		AllResources:            false,
+		CollectedResourceGroups: DefaultCollectedResourceGroups,
 	}
+
+	return options
 }
 
 func (o *MustGatherOptions) AddFlags(flagset *pflag.FlagSet) {
@@ -148,10 +152,12 @@ type resourceSpec struct {
 	Namespace, Name string
 }
 
-var mustGatherSpecs = []struct {
+type GroupResourceSpec struct {
 	schema.GroupResource
 	Namespace, Name string
-}{
+}
+
+var DefaultCollectedResourceGroups = []GroupResourceSpec{
 	{
 		GroupResource: schema.GroupResource{
 			Resource: "scyllaclusters",
@@ -286,8 +292,8 @@ func (o *MustGatherOptions) run(ctx context.Context) error {
 			return fmt.Errorf("can't discover preferred resources: %w", err)
 		}
 
-		resourceSpecs = make([]resourceSpec, 0, len(mustGatherSpecs))
-		for _, s := range mustGatherSpecs {
+		resourceSpecs = make([]resourceSpec, 0, len(o.CollectedResourceGroups))
+		for _, s := range o.CollectedResourceGroups {
 			ri, err := findResource(preferredResources, s.GroupResource)
 			if err != nil {
 				return fmt.Errorf("can't find resource in preferred resources: %w", err)