Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve analysis issues with sprite and block counts #11

Merged
merged 1 commit into from
May 24, 2017

Conversation

thisandagain
Copy link
Contributor

@thisandagain thisandagain commented May 12, 2017

Resolves GH-10

  • Greatly expands test depth for lib/analyze
  • Resolves issue where sprite count was inflated due to global variables and lists
  • Resolves issue where block counts were deflated due to improper handling of nested blocks

@thisandagain thisandagain requested a review from mewtaylor May 12, 2017 20:19
@thisandagain thisandagain changed the title Expand test coverage and resolve analysis issues with sprite and block counts Resolve analysis issues with sprite and block counts May 12, 2017
Resolves issue where sprite counts were inflated due to global variables and lists as well as an
issue where block counts were deflated due to improper handling of nested block structures

scratchfoundationGH-10
@thisandagain
Copy link
Contributor Author

Overwrote previous commit to comply with semantic-release setup.

Copy link
Contributor

@mewtaylor mewtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great – thanks for the additional tests, and the semantic commit!

@mewtaylor mewtaylor assigned thisandagain and unassigned mewtaylor May 24, 2017
@thisandagain thisandagain merged commit 040933f into scratchfoundation:develop May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants