Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Blocks count in _meta #10

Closed
sammoh94 opened this issue May 8, 2017 · 0 comments
Closed

Incorrect Blocks count in _meta #10

sammoh94 opened this issue May 8, 2017 · 0 comments
Assignees
@thisandagain
Labels
bug has patch

Comments

@sammoh94
Copy link

sammoh94 commented May 8, 2017

  • Running the scratch-parser on a project resulted in an incorrect blocks count. The correct count should be 20 but the results shows 9.
  • The screenshots from the project and the results from running the scratch-parser are pasted below.

screen shot 2017-05-08 at 4 38 04 pm

image

image
@thisandagain thisandagain self-assigned this May 8, 2017
thisandagain added a commit to thisandagain/scratch-parser that referenced this issue May 12, 2017
@thisandagain
Expand test coverage and resolve analysis issues with sprite and bloc…
1eb4b2e 
…k counts. Resolves scratchfoundationGH-10
@thisandagain thisandagain mentioned this issue May 12, 2017
Merged
thisandagain added a commit to thisandagain/scratch-parser that referenced this issue May 12, 2017
@thisandagain
fix(analyze): Resolve issues with block and sprite counts
bf56efd 
Resolves issue where sprite counts were inflated due to global variables and lists as well as an
issue where block counts were deflated due to improper handling of nested block structures

scratchfoundationGH-10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisandagain thisandagain

Labels
bug has patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thisandagain @sammoh94