-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Use sphinxcontrib-bibtex v2.1 and bibtex_bibfiles setting #1221
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1221 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 63 63
Lines 3716 3716
Branches 525 525
=======================================
Hits 3622 3622
Misses 55 55
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
* Compare floats to floats and not tensors in pytest.approx * Add pytest and uproot3 to HEAD of dependencies workflow * Restrict sphinxcontrib-bibtex to v1.X - c.f. PR #1221
5c94073
to
58471e6
Compare
I don't know how to get this to work on the RTD tests. |
a8ca93a
to
c674121
Compare
All issues are resolved with |
Description
Requiresphinxcontrib-bibtex
releases compatible withv2.0
, which requires the definition of thebibtex_bibfiles
in the Sphinxconf.py
. Withv2.0
Sphinx must be run twice to generate the bibliography:Require
sphinxcontrib-bibtex
releases compatible withv2.1
, which requires the definition of thebibtex_bibfiles
in the Sphinxconf.py
, thanks to mcmtroffaes/sphinxcontrib-bibtex#219 making thesphinxcontrib-bibtex
v2.1
release series able to run with a single pass through a Sphinx build. 🎉Requires PR #1220 to go in first.
ReadTheDocs build: https://pyhf.readthedocs.io/en/docs-use-sphinxcontrib-bibtex-v2.0/
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: