Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure pytest.approx only compares floats #1220

Merged
merged 4 commits into from
Dec 13, 2020

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Dec 13, 2020

Description

Resolves #1219

In response to Issue #1219, this PR avoids the issues that pytest v6.2.0 brings by restricting pytest to the v6.1.X series.
This PR ensures that there floats are compared instead of floats to tensors. To try to catch these sorts of issues sooner and maybe bring them up with the pytest devs add pytest to the HEAD of dependencies workflow as well.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Compare floats to floats and not tensors in pytest.approx
* Add pytest and uproot3 to HEAD of dependencies workflow
* Restrict sphinxcontrib-bibtex to v1.X
   - c.f. PR #1221

@matthewfeickert matthewfeickert added tests pytest fix A bug fix labels Dec 13, 2020
@matthewfeickert matthewfeickert self-assigned this Dec 13, 2020
@codecov
Copy link

codecov bot commented Dec 13, 2020

Codecov Report

Merging #1220 (524fc96) into master (f824afe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1220   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files          63       63           
  Lines        3688     3688           
  Branches      524      524           
=======================================
  Hits         3594     3594           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
unittests 97.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f824afe...524fc96. Read the comment docs.

@matthewfeickert matthewfeickert force-pushed the fix/restirct-pytest-to-under-6.2 branch from be1f01d to 87136f7 Compare December 13, 2020 06:46
@matthewfeickert matthewfeickert changed the title fix: Restrict pytest to v6.1.X release series fix: Ensure pytest.approx only compares floats Dec 13, 2020
@matthewfeickert matthewfeickert merged commit a35161e into master Dec 13, 2020
@matthewfeickert matthewfeickert deleted the fix/restirct-pytest-to-under-6.2 branch December 13, 2020 16:36
@matthewfeickert matthewfeickert mentioned this pull request Dec 14, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest v6.2.0 causing test_optim_with_value to fail
2 participants