Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs with new Ruby deployment #147

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Feb 22, 2024

We were seeing the following error while building on netlify:

3:36:19 PM: bundle install)
3:36:20 PM: Successfully installed bundler-2.4.22
3:36:20 PM: Parsing documentation for bundler-2.4.22
3:36:20 PM: Done installing documentation for bundler after 0 seconds
3:36:20 PM: 1 gem installed
3:36:20 PM: /opt/buildhome/.rvm/gems/ruby-3.3.0/bin/bundle: 6: exec: /opt/buildhome/.rvm/gems/ruby-3.3.0/bin/ruby: not found
3:36:20 PM: make: *** [Makefile:14: cookie_ruby_deps] Error 127

I noticed that during intialization on netlify we were seeing

3:36:05 PM: Required ruby-3.3.0 is not installed.
3:36:05 PM: To install do: "rvm install "ruby-3.3.0""
3:36:05 PM: Attempting Ruby version 3.3.0, read from .ruby-version file
3:36:05 PM: Started restoring cached Ruby version
3:36:06 PM: Finished restoring cached Ruby version
3:36:06 PM: Using Ruby version 3.3.0

I also noticed this PR on cookie: scientific-python/cookie#378

@henryiii I don't use ruby, so it would be great if someone who knows what they are doing could review this.

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for learn-scientific-python-org ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit df51c04
🔍 Latest deploy log https://app.netlify.com/sites/learn-scientific-python-org/deploys/65d7d700888a920008bb7cf0
😎 Deploy Preview https://deploy-preview-147--learn-scientific-python-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86
Accessibility: 97
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be working, so I think it’s OK.

@jarrodmillman jarrodmillman merged commit cebdcc3 into scientific-python:main Feb 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants