Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build docs with new Ruby deployment #378

Merged
merged 2 commits into from
Feb 12, 2024
Merged

ci: build docs with new Ruby deployment #378

merged 2 commits into from
Feb 12, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii closed this Feb 12, 2024
@henryiii henryiii reopened this Feb 12, 2024
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
Copy link
Collaborator Author

henryiii commented Feb 12, 2024

@MSanKeys963, this now builds in <1 minute with the new native Ruby support on ReadTheDocs! 🎉

@stefanv or @jarrodmillman, we still don't get the nice PR integration, ReadTheDocs says:

Warning

Could not send GitHub build status report for "scientific-python-cookie". Make sure you have the correct GitHub repository permissions and your GitHub account is connected to Read the Docs.

Could not send GitHub build status report for "repo-review". Make sure you have the correct GitHub repository permissions and your GitHub account is connected to Read the Docs.

I've manually set the web hook, so it does build, it just doesn't update the PR with the link in the checks list.

@stefanv
Copy link
Member

stefanv commented Feb 12, 2024

@henryiii I signed into RTD and gave it permissions, so hopefully it works now. But let me know if I need to do anything else.

@henryiii henryiii closed this Feb 12, 2024
@henryiii henryiii reopened this Feb 12, 2024
@henryiii
Copy link
Collaborator Author

Working, thanks!

@henryiii henryiii merged commit 4515a1d into main Feb 12, 2024
10 checks passed
@henryiii henryiii deleted the henryiii/ci/ruby branch February 12, 2024 23:44
jarrodmillman added a commit to jarrodmillman/learn.scientific-python.org that referenced this pull request Feb 22, 2024
jarrodmillman added a commit to scientific-python/learn.scientific-python.org that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants