monitor_utils.k8s: Prevent infinite looping when discovering k8s Custom Resources #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xdvpser Thanks for the contribution. Did you eventually manage to confirm that the bug indeed lies in that piece of code or that's just one of the suspects? I'm also looking at adding a test case for it, but it looks like adding an end to end tests will be hard so we may need to live with a mock based unit test in the short term. |
@Kami Hi! Yes, after applying changes in this PR, building and deploying to our servers, it started working properly. |
1 task
Kami
pushed a commit
that referenced
this pull request
Oct 4, 2022
* monitor_utils.k8s: Prevent infinite looping when discovering k8s Custom Resources * Add basic mock based unit tests for handling of controller info based edge cases in PodProcessor class. * Update log message. * Add changelog entry. * Remove specialized Docker image build which is not needed anymore. Co-authored-by: Nurbek Turdaliev <[email protected]>
|
Merged into master via #1004 - thanks! New dev build of Docker image with those changes should be available shortly (after CI finishes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #998