-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for #999 (k8s cache PodProcessor infinite loop issue) #1004
Conversation
edge cases in PodProcessor class.
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
+ Coverage 79.94% 79.97% +0.03%
==========================================
Files 181 181
Lines 41654 41731 +77
Branches 4679 4688 +9
==========================================
+ Hits 33299 33372 +73
- Misses 7218 7222 +4
Partials 1137 1137
|
Test Results 33 files ±0 33 suites ±0 59m 45s ⏱️ + 3m 18s For more details on these failures, see this check. Results for commit 4306f6c. ± Comparison against base commit b98e8a6. ♻️ This comment has been updated with latest results. |
This pull request is based on top of #999 and adds some basic mock based (regression) unit tests for a bug fix in #999.
Also having end to end tests would be ideal, but setting up the environment to be able to exercise this code path in the end to end tests would be quite cumbersome.
TODO