Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): deprecate an argument #1411

Merged
merged 4 commits into from
Sep 14, 2020

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Sep 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Description

This PR introduces the handling of deprecated arguments with the example of the organization-id field of scw instance server create:

  • Add a Deprecated bool argument to core.ArgSpec
  • Add a new DEPRECATED ARGS for deprecated args in the command usage.
  • Ignore deprecated arguments in autocomplete
  • Print a warning when a deprecated argument is used: The argument 'organization-id' is deprecated, more info with: scw instance server create --help

The addition of the project-id field is already done in #1410, I will rebase on this one when it will be merged.

Next Steps

Update the generator to fill the core.ArgSpec.Depreacred field.

Release note for CHANGELOG:

Handle deprecated arguments

remyleone
remyleone previously approved these changes Sep 9, 2020
kindermoumoute
kindermoumoute previously approved these changes Sep 14, 2020
@QuentinBrosse QuentinBrosse merged commit 28a90f4 into scaleway:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants