Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): rename project to project-id #1410

Merged
merged 8 commits into from
Sep 9, 2020
Merged

feat(instance): rename project to project-id #1410

merged 8 commits into from
Sep 9, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Sep 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@QuentinBrosse QuentinBrosse mentioned this pull request Sep 8, 2020
Merged
QuentinBrosse
QuentinBrosse suggested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enjoy

internal/namespaces/instance/v1/custom_image.go Outdated Show resolved Hide resolved
internal/namespaces/instance/v1/custom_image.go Outdated Show resolved Hide resolved
cmd/scw/testdata/test-all-usage-instance-image-create-usage.golden Show resolved Hide resolved
cmd/scw/testdata/test-all-usage-instance-placement-group-create-usage.golden Show resolved Hide resolved
cmd/scw/testdata/test-all-usage-instance-security-group-update-usage.golden Show resolved Hide resolved
cmd/scw/testdata/test-all-usage-instance-volume-list-usage.golden Show resolved Hide resolved
cmd/scw/testdata/test-all-usage-rdb-certificate-get-usage.golden Show resolved Hide resolved
go.sum Show resolved Hide resolved
internal/namespaces/instance/v1/custom_server_create.go Show resolved Hide resolved
internal/namespaces/instance/v1/custom_server_create.go Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute previously approved these changes Sep 9, 2020
View reviewed changes
Sh4d1 added 8 commits September 9, 2020 16:50
@Sh4d1
feat(instance): rename project to project-id
ecaaaaf 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
test(instance): bump goldens
4261b57 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
chore(core): bump sdk
56f9206 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
fix review
ad85a14 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
fix review
c39080e 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
update goldens
0126576 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
bump cassettes
d0a30c7 
Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1
go mod tidy
de3771c 
Signed-off-by: Patrik Cyvoct <[email protected]>
QuentinBrosse
QuentinBrosse approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit f7ee6a4 into master Sep 9, 2020
@kindermoumoute kindermoumoute deleted the instance_project branch September 9, 2020 15:59
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sh4d1 @kindermoumoute @QuentinBrosse @remyleone