Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Broken autofix for top-level block comment with multiline text #661

Merged
merged 12 commits into from
Dec 24, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Dec 22, 2020

What's done:

  • Fixed bug

This pull request closes #651 #649

### What's done:
  * Fixed bug
@aktsay6 aktsay6 added the bug Something isn't working label Dec 22, 2020
@aktsay6 aktsay6 requested review from petertrr and kentr0w December 22, 2020 07:18
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #661 (b41d6af) into master (f74d7ff) will increase coverage by 0.02%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #661      +/-   ##
============================================
+ Coverage     79.23%   79.26%   +0.02%     
- Complexity     1799     1803       +4     
============================================
  Files            87       87              
  Lines          4695     4706      +11     
  Branches       1508     1510       +2     
============================================
+ Hits           3720     3730      +10     
  Misses          280      280              
- Partials        695      696       +1     
Flag Coverage Δ Complexity Δ
unittests 79.26% <92.85%> (+0.02%) 0.00 <4.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...diktat/ruleset/rules/comments/HeaderCommentRule.kt 84.37% <92.85%> (+0.84%) 42.00 <4.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74d7ff...b41d6af. Read the comment docs.

@kentr0w
Copy link
Collaborator

kentr0w commented Dec 22, 2020

Look at this issue, I think you can fix it in this PR

### What's done:
  * Added
@aktsay6 aktsay6 requested a review from petertrr December 23, 2020 10:42
### What's done:
  * Fixed bug
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 requested a review from petertrr December 24, 2020 12:55
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 requested a review from petertrr December 24, 2020 13:33
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aktsay6 aktsay6 merged commit dcd1433 into master Dec 24, 2020
@aktsay6 aktsay6 deleted the bugfix/top-level-block-comment(#651) branch December 24, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken autofix for top-level block comment with multiline text
3 participants