Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. CommentedCode when text inside block comment may be interpreted as KDoc #664

Merged
merged 8 commits into from
Dec 24, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Dec 23, 2020

What's done:

  • Fixed bug
  • Added tests

The bug was in the way block comments opening and closing tokens were removed

This pull request closes #652

### What's done:
  * Added tests
### What's done:
  * Fixed bug
@aktsay6 aktsay6 added the bug Something isn't working label Dec 23, 2020
@aktsay6 aktsay6 requested review from petertrr and kentr0w December 23, 2020 12:47
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #664 (9f136cb) into master (dcd1433) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #664   +/-   ##
=========================================
  Coverage     79.26%   79.26%           
- Complexity     1803     1804    +1     
=========================================
  Files            87       87           
  Lines          4706     4706           
  Branches       1510     1511    +1     
=========================================
  Hits           3730     3730           
  Misses          280      280           
  Partials        696      696           
Flag Coverage Δ Complexity Δ
unittests 79.26% <0.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...cqfn/diktat/ruleset/rules/comments/CommentsRule.kt 94.64% <0.00%> (-1.79%) 22.00 <0.00> (ø)
.../cqfn/diktat/ruleset/rules/BlockStructureBraces.kt 79.64% <0.00%> (+0.88%) 54.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcd1433...9f136cb. Read the comment docs.

@aktsay6 aktsay6 changed the title Bugfix/commented code fp(#652) Bugfix. CommentedCode when text inside block comment may be interpreted as KDoc Dec 23, 2020
### What's done:
  * Fixed bug
### What's done:
  * Added fix test
@aktsay6 aktsay6 requested a review from petertrr December 24, 2020 14:56
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 merged commit ee08aa4 into master Dec 24, 2020
@aktsay6 aktsay6 deleted the bugfix/commented-code-fp(#652) branch December 24, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FP] CommentedCode when text inside block comment may be interpreted as KDoc
2 participants