Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle prefix and postfix operators in WhiteSpaceRule (#416) #437

Merged
merged 8 commits into from
Oct 26, 2020

Conversation

petertrr
Copy link
Member

What's done:

  • Fixed logic
  • Added tests

This pull request closes #416

### What's done:
* Fixed logic
* Added tests
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #437 into master will decrease coverage by 0.08%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #437      +/-   ##
============================================
- Coverage     82.04%   81.95%   -0.09%     
+ Complexity     1436     1435       -1     
============================================
  Files            69       69              
  Lines          3586     3591       +5     
  Branches       1143     1147       +4     
============================================
+ Hits           2942     2943       +1     
  Misses          201      201              
- Partials        443      447       +4     
Flag Coverage Δ Complexity Δ
#unittests 81.95% <83.33%> (-0.09%) 1435.00 <3.00> (-1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...in/org/cqfn/diktat/ruleset/rules/WhiteSpaceRule.kt 78.16% <83.33%> (-2.13%) 125.00 <3.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81f528...4f2dc8f. Read the comment docs.

@petertrr petertrr requested review from aktsay6 and kentr0w October 22, 2020 08:35
### What's done:
* Added example with extesnsion function to tests
…pace#416

# Conflicts:
#	diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/smoke/DiktatSmokeTest.kt
### What's done:
* Fixes after merge
Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Guess we should write about prefix and postfix operators in kdoc.

@petertrr
Copy link
Member Author

lgtm. Guess we should write about prefix and postfix operators in kdoc.

good point, added

@petertrr petertrr merged commit 4a6060d into master Oct 26, 2020
@petertrr petertrr deleted the bugfix/wrong-whitespace#416 branch October 26, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WRONG_WHITESPACE incorrectly handles postfix operators
2 participants