Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRONG_WHITESPACE incorrectly handles postfix operators #416

Closed
petertrr opened this issue Oct 16, 2020 · 0 comments · Fixed by #437
Closed

WRONG_WHITESPACE incorrectly handles postfix operators #416

petertrr opened this issue Oct 16, 2020 · 0 comments · Fixed by #437
Assignees
@petertrr
Labels
bug Something isn't working

Comments

@petertrr
Copy link
Member

petertrr commented Oct 16, 2020 •
edited
Loading

Describe the bug

return element++
[WRONG_WHITESPACE] incorrect usage of whitespaces for code separation: ++ should have 1 space(s) before and 1 space(s) after, but has 0 space(s) before

Should check prefix operators too, and not break infix functions.

Environment information

  • diktat version: 0.1.2
@petertrr petertrr added the bug Something isn't working label Oct 16, 2020
@petertrr petertrr self-assigned this Oct 22, 2020
petertrr added a commit that referenced this issue Oct 22, 2020
@petertrr
Issue #416
e68c0d5 
### What's done:
* Fixed logic
* Added tests
@petertrr petertrr mentioned this issue Oct 22, 2020
Merged
petertrr added a commit that referenced this issue Oct 22, 2020
@petertrr
Issue #416
de3cc79 
### What's done:
* Added example with extesnsion function to tests
petertrr added a commit that referenced this issue Oct 23, 2020
@petertrr
Issue #416
f6ed1b6 
### What's done:
* Fixes after merge
petertrr added a commit that referenced this issue Oct 26, 2020
@petertrr
Issue #416
5d9160a 
### What's done:
* Added docs
petertrr added a commit that referenced this issue Oct 26, 2020
@petertrr
Correctly handle prefix and postfix operators in WhiteSpaceRule (#416) (
4a6060d 
#437)

### What's done:
* Fixed logic
* Added tests
* Added example with extension function to tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petertrr petertrr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly handle prefix and postfix operators in WhiteSpaceRule (#416) saveourtool/diktat
1 participant
@petertrr