Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add employee field throughout files #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laurenbrissette
Copy link
Contributor

Description

Added an isAdmin field to Employee schema, dto, and Employee service.

Motivation and Context

To allow for admin functionality to be implemented.

Closes [#238 ]

How has this been tested?

The site was able to compile and run after the changes we made.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Co-authored-by: Gayatri Kondabathini <[email protected]>
@laurenbrissette laurenbrissette linked an issue Jan 25, 2025 that may be closed by this pull request
4 tasks
Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 9:14pm

Copy link
Contributor

@ahweigl ahweigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@elvincheng3
Copy link
Contributor

Would using some form of scopes be more flexible?

@kaiyangzheng
Copy link
Collaborator

Would using some form of scopes be more flexible?

What would this look like? Many different roles, or defining what a user has access to?

@elvincheng3
Copy link
Contributor

elvincheng3 commented Jan 27, 2025

Would using some form of scopes be more flexible?

What would this look like? Many different roles, or defining what a user has access to?

Defining what a user has access to; would also make it easy to extend to roles in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create "admin" field for employees
4 participants