Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default match in column reference #172

Merged
merged 2 commits into from
Feb 5, 2018
Merged

Remove default match in column reference #172

merged 2 commits into from
Feb 5, 2018

Conversation

charsleysa
Copy link
Contributor

This change causes column definitions to no longer output MATCH SIMPLE on references.

Databases by default use MATCH SIMPLE so it is not needed.

This change will add support to some databases (e.g. CockroachDB) which do not yet support the [MATCH (FULL | PARTIAL | SIMPLE)] syntax.

Copy link
Contributor

@dolezel dolezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Yes, the default is not needed, I just wanted to make it clear what it is doing, but if removing default can help to support other DB engine, I'm for it.

Just please fix tests to make them pass. 🙏

@charsleysa
Copy link
Contributor Author

Sorry I hadn't noticed that the tests had broken.

I've committed a fix with an extra test to make sure the clause is added when specified.

Copy link
Contributor

@dolezel dolezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dolezel dolezel merged commit 577f1ee into salsita:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants