Remove default match in column reference (#172)

* - Remove default match * - Fix tests
salsita · Feb 5, 2018 · 577f1ee · 577f1ee
1 parent 6ec3ffa
commit 577f1ee
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/lib/operations/tables.js b/lib/operations/tables.js
@@ -7,7 +7,7 @@ const formatLines = (lines, replace, separator = ',\n') =>
 const parseReferences = (options) => {
   const {
     references,
-    match = 'SIMPLE',
+    match,
     onDelete,
     onUpdate,
   } = options;

diff --git a/test/tables-test.js b/test/tables-test.js
@@ -32,14 +32,27 @@ describe('lib/operations/tables', () => {
         },
       });
       expect(sql).to.equal(`CREATE TABLE "my_table_name" (
+  "parent_id" integer REFERENCES "a"."b"
+);`);
+    });
+
+    it('check match clause can be used for foreign keys', () => {
+      const sql = Tables.create()('my_table_name', {
+        parent_id: {
+          type: 'integer',
+          references: { schema: 'a', name: 'b' },
+          match: 'SIMPLE',
+        },
+      });
+      expect(sql).to.equal(`CREATE TABLE "my_table_name" (
   "parent_id" integer REFERENCES "a"."b" MATCH SIMPLE
 );`);
     });
 
     it('check defining column can be used for foreign keys', () => {
       const sql = Tables.create()('my_table_name', { parent_id: { type: 'integer', references: 'a.b(id)' } });
       expect(sql).to.equal(`CREATE TABLE "my_table_name" (
-  "parent_id" integer REFERENCES a.b(id) MATCH SIMPLE
+  "parent_id" integer REFERENCES a.b(id)
 );`);
     });
 
@@ -76,7 +89,7 @@ describe('lib/operations/tables', () => {
       expect(sql).to.equal(`CREATE TABLE "my_table_name" (
   "a" integer,
   "b" varchar,
-  FOREIGN KEY ("a", "b") REFERENCES otherTable (A, B) MATCH SIMPLE
+  FOREIGN KEY ("a", "b") REFERENCES otherTable (A, B)
 );`);
     });